[ORC-394][C++] Add addUserMetadata() function to C++ write#300
Closed
czxrrr wants to merge 1 commit into
Closed
Conversation
| } | ||
| } | ||
|
|
||
| TEST_P(WriterTest, writeUserMetadata) { |
Contributor
There was a problem hiding this comment.
can you add the user metadata check to an existing test?
czxrrr
force-pushed
the
ORC-394
branch
4 times, most recently
from
4c0a6a3 to
a294a3b
Compare
Contributor
|
Looks good. Thanks for adding this. |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2018
Fixes #300 Signed-off-by: Deepak Majeti <mdeepak@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit aims to provide API to add Usermetadata into FileFooter.