ORC-442: [C++] Code improvements in Statistics and Writer.#343
Closed
fangzheng wants to merge 1 commit intoapache:masterfrom
Closed
ORC-442: [C++] Code improvements in Statistics and Writer.#343fangzheng wants to merge 1 commit intoapache:masterfrom
fangzheng wants to merge 1 commit intoapache:masterfrom
Conversation
majetideepak
approved these changes
Dec 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few code changes in Statistics and Writer classes:
Change StatisticsImpl to use vector instead of list for storing ColumnStatistics. Because the required operations are push_back() in ctor, iteration in dtor, and random element access in getColumnStatistics(), and list does not support random access in constant time, vector would be more appropriate than list.
InternalBooleanStatistics is currently typedef-ed as InternalStatisticsImpl<uint64_t>. Since min/max/sum does not apply to BooleanColumnStatistics, we should define InternalBooleanStatistics to be InternalStatisticsImpl to save 21 bytes per instance.
Misc. changes to ColumnWriter.hh, Writer.cc, Compression.hh, and Statistics.hh to fix typos in Doxygen and reduce object copies.