ORC-443: [C++] Code improvements in ColumnWriter.#344
Merged
wgtmac merged 4 commits intoapache:masterfrom Dec 3, 2018
Merged
Conversation
fangzheng
changed the title
wgtmac
reviewed
Nov 30, 2018
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Overall LGTM, only some small styling changes are needed. Thanks!
c++/src/ByteRLE.cc
Outdated
| /** | ||
| * Flushing underlying BufferedOutputStream | ||
| * Flush underlying BufferedOutputStream. | ||
| */ |
c++/src/ColumnWriter.cc
Outdated
|
|
||
| DoubleColumnStatisticsImpl* doubleStats = | ||
| dynamic_cast<DoubleColumnStatisticsImpl*>(colIndexStatistics.get()); | ||
| dynamic_cast<DoubleColumnStatisticsImpl*>(colIndexStatistics.get()); |
c++/src/ColumnWriter.cc
Outdated
| const int64_t* values = decBatch->values.data() + offset; | ||
| DecimalColumnStatisticsImpl* decStats = | ||
| dynamic_cast<DecimalColumnStatisticsImpl*>(colIndexStatistics.get()); | ||
| dynamic_cast<DecimalColumnStatisticsImpl*>(colIndexStatistics.get()); |
Contributor
Author
|
Thanks, Gang! All the codes are fixed now. |
wgtmac
approved these changes
Nov 30, 2018
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks @fangzheng ! I will merge this and your previous one next week in case someone else wants to review.
majetideepak
approved these changes
Dec 2, 2018
Contributor
|
@fangzheng can you please resolve the conflict? Thanks. |
Contributor
Author
|
@majetideepak Hi Deepak, the conflicts have been resolved. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in add() function, re-order code to verify input parameters before modifying any internal state.
in add() function, move the calls to colIndexStatistics->increase(1) out of the loop.