Skip to content

Conversation

@yuruiz
Copy link
Contributor

@yuruiz yuruiz commented May 20, 2019

  • Move blob ownership from StringColumnReader to StringVectorBatch to avoid data overriden
  • Enforce memcpy on StringColumnReader to make sure string blob is owned by external user

enforce string memcpy on ColumnReader to make sure blob content is owned by external user
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@wgtmac wgtmac merged commit ceef536 into apache:master May 24, 2019
moresandeep pushed a commit to moresandeep/orc that referenced this pull request May 28, 2019
…ctorBatch to avoid data overriden

This fixes apache#393

ORC-497 - Fix build failures for maven 3.6.x

Fixes apache#390

Signed-off-by: Owen O'Malley <omalley@apache.org>

Proto fix
dongjoon-hyun pushed a commit that referenced this pull request Jan 3, 2026
Bumps [commons-cli:commons-cli](https://github.com/apache/commons-cli) from 1.10.0 to 1.11.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/apache/commons-cli/blob/master/RELEASE-NOTES.txt">commons-cli:commons-cli's changelog</a>.</em></p>
<blockquote>
<h2>Apache Commons CLI 1.11.0 Release Notes</h2>
<p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p>
<p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p>
<p>This is a feature and maintenance release. Java 8 or later is required.</p>
<h2>New Features</h2>
<ul>
<li>
<pre><code>      Add CommandLine.getOptionCount() to measure option repetition [#396](apache/commons-cli#396). Thanks to David Larochette, Gary Gregory.
</code></pre>
</li>
</ul>
<h2>Fixed Bugs</h2>
<ul>
<li>CLI-351:  Multiple trailing BREAK_CHAR_SET characters cause infinite loop in HelpFormatter. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li>
<li>CLI-351:  Fix issue with groups not being reported in help output. <a href="https://redirect.github.com/apache/commons-cli/issues/411">#411</a>. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li>
</ul>
<h2>Updates</h2>
<ul>
<li>
<pre><code>      Bump org.apache.commons:commons-parent from 85 to 91 [#393](apache/commons-cli#393). Thanks to Gary Gregory, Dependabot.
</code></pre>
</li>
<li>
<pre><code>      Bump commons-io:commons-io from 2.20.0 to 2.21.0. Thanks to Gary Gregory.
</code></pre>
</li>
</ul>
<p>Historical list of changes: <a href="https://commons.apache.org/proper/commons-cli/changes.html">https://commons.apache.org/proper/commons-cli/changes.html</a></p>
<p>For complete information on Apache Commons CLI, including instructions on how to submit bug reports,
patches, or suggestions for improvement, see the Apache Commons CLI website:</p>
<p><a href="https://commons.apache.org/proper/commons-cli/">https://commons.apache.org/proper/commons-cli/</a></p>
<p>Download page: <a href="https://commons.apache.org/proper/commons-cli/download_cli.cgi">https://commons.apache.org/proper/commons-cli/download_cli.cgi</a></p>
<p>Have fun!
The Apache Commons Team</p>
<hr />
<h2>Apache Commons CLI 1.11.0 Release Notes</h2>
<p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p>
<p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p>
<p>This is a feature and maintenance release. Java 8 or later is required.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/apache/commons-cli/commit/d74613321325f6081fa0206c4ab608ab65d80e2e"><code>d746133</code></a> Prepare for the release candidate 1.11.0 RC1</li>
<li><a href="https://github.com/apache/commons-cli/commit/966ddd66b31e0608ecbd650a3eb2bb2426e26c22"><code>966ddd6</code></a> Prepare for the next release candidate</li>
<li><a href="https://github.com/apache/commons-cli/commit/234a34d61dc11a302358c92fd18ed702327c5e39"><code>234a34d</code></a> Use ternary to reduce duplication</li>
<li><a href="https://github.com/apache/commons-cli/commit/ef98fc4b9302fbf10e8b608dce0571d2bc066345"><code>ef98fc4</code></a> Better test assertions</li>
<li><a href="https://github.com/apache/commons-cli/commit/a9baf80a113c75885f53bb0dc34e6f9e15bc37b3"><code>a9baf80</code></a> No need to create an intermediary array</li>
<li><a href="https://github.com/apache/commons-cli/commit/4c464592162bbae53dd606ca56375ce92894e3cf"><code>4c46459</code></a> Reduce returns</li>
<li><a href="https://github.com/apache/commons-cli/commit/7108379d50938de7ac26de6d1c76ee6a0ef2845f"><code>7108379</code></a> Javadoc</li>
<li><a href="https://github.com/apache/commons-cli/commit/7199a701924f0ecf95d729095bc610d6434a3a77"><code>7199a70</code></a> Use forEachRemaining</li>
<li><a href="https://github.com/apache/commons-cli/commit/e852acf572129fa8b2e3824b0e23a32a074e832f"><code>e852acf</code></a> Reuse constants</li>
<li><a href="https://github.com/apache/commons-cli/commit/395346c58f510fcff79893d0adeb9961ab430a43"><code>395346c</code></a> Better exception message</li>
<li>Additional commits viewable in <a href="https://github.com/apache/commons-cli/compare/rel/commons-cli-1.10.0...rel/commons-cli-1.11.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-cli:commons-cli&package-manager=maven&previous-version=1.10.0&new-version=1.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Closes #2459 from dependabot[bot]/dependabot/maven/java/commons-cli-commons-cli-1.11.0.

Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun pushed a commit that referenced this pull request Jan 3, 2026
Bumps [commons-cli:commons-cli](https://github.com/apache/commons-cli) from 1.10.0 to 1.11.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/apache/commons-cli/blob/master/RELEASE-NOTES.txt">commons-cli:commons-cli's changelog</a>.</em></p>
<blockquote>
<h2>Apache Commons CLI 1.11.0 Release Notes</h2>
<p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p>
<p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p>
<p>This is a feature and maintenance release. Java 8 or later is required.</p>
<h2>New Features</h2>
<ul>
<li>
<pre><code>      Add CommandLine.getOptionCount() to measure option repetition [#396](apache/commons-cli#396). Thanks to David Larochette, Gary Gregory.
</code></pre>
</li>
</ul>
<h2>Fixed Bugs</h2>
<ul>
<li>CLI-351:  Multiple trailing BREAK_CHAR_SET characters cause infinite loop in HelpFormatter. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li>
<li>CLI-351:  Fix issue with groups not being reported in help output. <a href="https://redirect.github.com/apache/commons-cli/issues/411">#411</a>. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li>
</ul>
<h2>Updates</h2>
<ul>
<li>
<pre><code>      Bump org.apache.commons:commons-parent from 85 to 91 [#393](apache/commons-cli#393). Thanks to Gary Gregory, Dependabot.
</code></pre>
</li>
<li>
<pre><code>      Bump commons-io:commons-io from 2.20.0 to 2.21.0. Thanks to Gary Gregory.
</code></pre>
</li>
</ul>
<p>Historical list of changes: <a href="https://commons.apache.org/proper/commons-cli/changes.html">https://commons.apache.org/proper/commons-cli/changes.html</a></p>
<p>For complete information on Apache Commons CLI, including instructions on how to submit bug reports,
patches, or suggestions for improvement, see the Apache Commons CLI website:</p>
<p><a href="https://commons.apache.org/proper/commons-cli/">https://commons.apache.org/proper/commons-cli/</a></p>
<p>Download page: <a href="https://commons.apache.org/proper/commons-cli/download_cli.cgi">https://commons.apache.org/proper/commons-cli/download_cli.cgi</a></p>
<p>Have fun!
The Apache Commons Team</p>
<hr />
<h2>Apache Commons CLI 1.11.0 Release Notes</h2>
<p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p>
<p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p>
<p>This is a feature and maintenance release. Java 8 or later is required.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/apache/commons-cli/commit/d74613321325f6081fa0206c4ab608ab65d80e2e"><code>d746133</code></a> Prepare for the release candidate 1.11.0 RC1</li>
<li><a href="https://github.com/apache/commons-cli/commit/966ddd66b31e0608ecbd650a3eb2bb2426e26c22"><code>966ddd6</code></a> Prepare for the next release candidate</li>
<li><a href="https://github.com/apache/commons-cli/commit/234a34d61dc11a302358c92fd18ed702327c5e39"><code>234a34d</code></a> Use ternary to reduce duplication</li>
<li><a href="https://github.com/apache/commons-cli/commit/ef98fc4b9302fbf10e8b608dce0571d2bc066345"><code>ef98fc4</code></a> Better test assertions</li>
<li><a href="https://github.com/apache/commons-cli/commit/a9baf80a113c75885f53bb0dc34e6f9e15bc37b3"><code>a9baf80</code></a> No need to create an intermediary array</li>
<li><a href="https://github.com/apache/commons-cli/commit/4c464592162bbae53dd606ca56375ce92894e3cf"><code>4c46459</code></a> Reduce returns</li>
<li><a href="https://github.com/apache/commons-cli/commit/7108379d50938de7ac26de6d1c76ee6a0ef2845f"><code>7108379</code></a> Javadoc</li>
<li><a href="https://github.com/apache/commons-cli/commit/7199a701924f0ecf95d729095bc610d6434a3a77"><code>7199a70</code></a> Use forEachRemaining</li>
<li><a href="https://github.com/apache/commons-cli/commit/e852acf572129fa8b2e3824b0e23a32a074e832f"><code>e852acf</code></a> Reuse constants</li>
<li><a href="https://github.com/apache/commons-cli/commit/395346c58f510fcff79893d0adeb9961ab430a43"><code>395346c</code></a> Better exception message</li>
<li>Additional commits viewable in <a href="https://github.com/apache/commons-cli/compare/rel/commons-cli-1.10.0...rel/commons-cli-1.11.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-cli:commons-cli&package-manager=maven&previous-version=1.10.0&new-version=1.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Closes #2459 from dependabot[bot]/dependabot/maven/java/commons-cli-commons-cli-1.11.0.

Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit d49037e)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants