-
Notifications
You must be signed in to change notification settings - Fork 506
ORC-501: [C++]Move blob ownership from StringColumnReader to StringVectorBatch to avoid data overriden #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
May 20, 2019
enforce string memcpy on ColumnReader to make sure blob content is owned by external user
wgtmac
approved these changes
May 21, 2019
Member
wgtmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
moresandeep
pushed a commit
to moresandeep/orc
that referenced
this pull request
May 28, 2019
…ctorBatch to avoid data overriden This fixes apache#393 ORC-497 - Fix build failures for maven 3.6.x Fixes apache#390 Signed-off-by: Owen O'Malley <omalley@apache.org> Proto fix
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 3, 2026
Bumps [commons-cli:commons-cli](https://github.com/apache/commons-cli) from 1.10.0 to 1.11.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/apache/commons-cli/blob/master/RELEASE-NOTES.txt">commons-cli:commons-cli's changelog</a>.</em></p> <blockquote> <h2>Apache Commons CLI 1.11.0 Release Notes</h2> <p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p> <p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p> <p>This is a feature and maintenance release. Java 8 or later is required.</p> <h2>New Features</h2> <ul> <li> <pre><code> Add CommandLine.getOptionCount() to measure option repetition [#396](apache/commons-cli#396). Thanks to David Larochette, Gary Gregory. </code></pre> </li> </ul> <h2>Fixed Bugs</h2> <ul> <li>CLI-351: Multiple trailing BREAK_CHAR_SET characters cause infinite loop in HelpFormatter. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li> <li>CLI-351: Fix issue with groups not being reported in help output. <a href="https://redirect.github.com/apache/commons-cli/issues/411">#411</a>. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li> </ul> <h2>Updates</h2> <ul> <li> <pre><code> Bump org.apache.commons:commons-parent from 85 to 91 [#393](apache/commons-cli#393). Thanks to Gary Gregory, Dependabot. </code></pre> </li> <li> <pre><code> Bump commons-io:commons-io from 2.20.0 to 2.21.0. Thanks to Gary Gregory. </code></pre> </li> </ul> <p>Historical list of changes: <a href="https://commons.apache.org/proper/commons-cli/changes.html">https://commons.apache.org/proper/commons-cli/changes.html</a></p> <p>For complete information on Apache Commons CLI, including instructions on how to submit bug reports, patches, or suggestions for improvement, see the Apache Commons CLI website:</p> <p><a href="https://commons.apache.org/proper/commons-cli/">https://commons.apache.org/proper/commons-cli/</a></p> <p>Download page: <a href="https://commons.apache.org/proper/commons-cli/download_cli.cgi">https://commons.apache.org/proper/commons-cli/download_cli.cgi</a></p> <p>Have fun! The Apache Commons Team</p> <hr /> <h2>Apache Commons CLI 1.11.0 Release Notes</h2> <p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p> <p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p> <p>This is a feature and maintenance release. Java 8 or later is required.</p> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/apache/commons-cli/commit/d74613321325f6081fa0206c4ab608ab65d80e2e"><code>d746133</code></a> Prepare for the release candidate 1.11.0 RC1</li> <li><a href="https://github.com/apache/commons-cli/commit/966ddd66b31e0608ecbd650a3eb2bb2426e26c22"><code>966ddd6</code></a> Prepare for the next release candidate</li> <li><a href="https://github.com/apache/commons-cli/commit/234a34d61dc11a302358c92fd18ed702327c5e39"><code>234a34d</code></a> Use ternary to reduce duplication</li> <li><a href="https://github.com/apache/commons-cli/commit/ef98fc4b9302fbf10e8b608dce0571d2bc066345"><code>ef98fc4</code></a> Better test assertions</li> <li><a href="https://github.com/apache/commons-cli/commit/a9baf80a113c75885f53bb0dc34e6f9e15bc37b3"><code>a9baf80</code></a> No need to create an intermediary array</li> <li><a href="https://github.com/apache/commons-cli/commit/4c464592162bbae53dd606ca56375ce92894e3cf"><code>4c46459</code></a> Reduce returns</li> <li><a href="https://github.com/apache/commons-cli/commit/7108379d50938de7ac26de6d1c76ee6a0ef2845f"><code>7108379</code></a> Javadoc</li> <li><a href="https://github.com/apache/commons-cli/commit/7199a701924f0ecf95d729095bc610d6434a3a77"><code>7199a70</code></a> Use forEachRemaining</li> <li><a href="https://github.com/apache/commons-cli/commit/e852acf572129fa8b2e3824b0e23a32a074e832f"><code>e852acf</code></a> Reuse constants</li> <li><a href="https://github.com/apache/commons-cli/commit/395346c58f510fcff79893d0adeb9961ab430a43"><code>395346c</code></a> Better exception message</li> <li>Additional commits viewable in <a href="https://github.com/apache/commons-cli/compare/rel/commons-cli-1.10.0...rel/commons-cli-1.11.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Closes #2459 from dependabot[bot]/dependabot/maven/java/commons-cli-commons-cli-1.11.0. Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 3, 2026
Bumps [commons-cli:commons-cli](https://github.com/apache/commons-cli) from 1.10.0 to 1.11.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/apache/commons-cli/blob/master/RELEASE-NOTES.txt">commons-cli:commons-cli's changelog</a>.</em></p> <blockquote> <h2>Apache Commons CLI 1.11.0 Release Notes</h2> <p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p> <p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p> <p>This is a feature and maintenance release. Java 8 or later is required.</p> <h2>New Features</h2> <ul> <li> <pre><code> Add CommandLine.getOptionCount() to measure option repetition [#396](apache/commons-cli#396). Thanks to David Larochette, Gary Gregory. </code></pre> </li> </ul> <h2>Fixed Bugs</h2> <ul> <li>CLI-351: Multiple trailing BREAK_CHAR_SET characters cause infinite loop in HelpFormatter. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li> <li>CLI-351: Fix issue with groups not being reported in help output. <a href="https://redirect.github.com/apache/commons-cli/issues/411">#411</a>. Thanks to Damien Carbonne, Claude Warren, Gary Gregory.</li> </ul> <h2>Updates</h2> <ul> <li> <pre><code> Bump org.apache.commons:commons-parent from 85 to 91 [#393](apache/commons-cli#393). Thanks to Gary Gregory, Dependabot. </code></pre> </li> <li> <pre><code> Bump commons-io:commons-io from 2.20.0 to 2.21.0. Thanks to Gary Gregory. </code></pre> </li> </ul> <p>Historical list of changes: <a href="https://commons.apache.org/proper/commons-cli/changes.html">https://commons.apache.org/proper/commons-cli/changes.html</a></p> <p>For complete information on Apache Commons CLI, including instructions on how to submit bug reports, patches, or suggestions for improvement, see the Apache Commons CLI website:</p> <p><a href="https://commons.apache.org/proper/commons-cli/">https://commons.apache.org/proper/commons-cli/</a></p> <p>Download page: <a href="https://commons.apache.org/proper/commons-cli/download_cli.cgi">https://commons.apache.org/proper/commons-cli/download_cli.cgi</a></p> <p>Have fun! The Apache Commons Team</p> <hr /> <h2>Apache Commons CLI 1.11.0 Release Notes</h2> <p>The Apache Commons CLI team is pleased to announce the release of Apache Commons CLI 1.11.0.</p> <p>Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface.</p> <p>This is a feature and maintenance release. Java 8 or later is required.</p> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/apache/commons-cli/commit/d74613321325f6081fa0206c4ab608ab65d80e2e"><code>d746133</code></a> Prepare for the release candidate 1.11.0 RC1</li> <li><a href="https://github.com/apache/commons-cli/commit/966ddd66b31e0608ecbd650a3eb2bb2426e26c22"><code>966ddd6</code></a> Prepare for the next release candidate</li> <li><a href="https://github.com/apache/commons-cli/commit/234a34d61dc11a302358c92fd18ed702327c5e39"><code>234a34d</code></a> Use ternary to reduce duplication</li> <li><a href="https://github.com/apache/commons-cli/commit/ef98fc4b9302fbf10e8b608dce0571d2bc066345"><code>ef98fc4</code></a> Better test assertions</li> <li><a href="https://github.com/apache/commons-cli/commit/a9baf80a113c75885f53bb0dc34e6f9e15bc37b3"><code>a9baf80</code></a> No need to create an intermediary array</li> <li><a href="https://github.com/apache/commons-cli/commit/4c464592162bbae53dd606ca56375ce92894e3cf"><code>4c46459</code></a> Reduce returns</li> <li><a href="https://github.com/apache/commons-cli/commit/7108379d50938de7ac26de6d1c76ee6a0ef2845f"><code>7108379</code></a> Javadoc</li> <li><a href="https://github.com/apache/commons-cli/commit/7199a701924f0ecf95d729095bc610d6434a3a77"><code>7199a70</code></a> Use forEachRemaining</li> <li><a href="https://github.com/apache/commons-cli/commit/e852acf572129fa8b2e3824b0e23a32a074e832f"><code>e852acf</code></a> Reuse constants</li> <li><a href="https://github.com/apache/commons-cli/commit/395346c58f510fcff79893d0adeb9961ab430a43"><code>395346c</code></a> Better exception message</li> <li>Additional commits viewable in <a href="https://github.com/apache/commons-cli/compare/rel/commons-cli-1.10.0...rel/commons-cli-1.11.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Closes #2459 from dependabot[bot]/dependabot/maven/java/commons-cli-commons-cli-1.11.0. Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d49037e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.