Skip to content

ORC-626: Reading Struct Column Having Multiple Fields With Same Name Causes java.io.EOFException#505

Closed
shameersss1 wants to merge 1 commit intoapache:masterfrom
shameersss1:ORC-626
Closed

ORC-626: Reading Struct Column Having Multiple Fields With Same Name Causes java.io.EOFException#505
shameersss1 wants to merge 1 commit intoapache:masterfrom
shameersss1:ORC-626

Conversation

@shameersss1
Copy link
Copy Markdown

@shameersss1 shameersss1 commented May 3, 2020

Steps To Repro In Hive:

`set hive.fetch.task.conversion=none;
set orc.force.positional.evolution=true;

create table complex_orc(device struct<a:string,a:string,b:string>) stored as orc;
insert into complex_orc select named_struct("a","123","a","823","b","23");
select * from complex_orc;`
Fails with the following exception:

Caused by: java.io.EOFException: Read past end of RLE integer from compressed stream Stream for column 3 kind LENGTH position: 6 length: 6 range: 0 offset: 16 limit: 16 range 0 = 0 to 6 uncompressed: 3 to 3 at org.apache.orc.impl.RunLengthIntegerReaderV2.readValues(RunLengthIntegerReaderV2.java:61) at org.apache.orc.impl.RunLengthIntegerReaderV2.next(RunLengthIntegerReaderV2.java:323) at org.apache.orc.impl.RunLengthIntegerReaderV2.nextVector(RunLengthIntegerReaderV2.java:369) at org.apache.orc.impl.TreeReaderFactory$BytesColumnVectorUtil.commonReadByteArrays(TreeReaderFactory.java:1299) at org.apache.orc.impl.TreeReaderFactory$BytesColumnVectorUtil.readOrcByteArrays(TreeReaderFactory.java:1336) at org.apache.orc.impl.TreeReaderFactory$StringDirectTreeReader.nextVector(TreeReaderFactory.java:1434) at org.apache.orc.impl.TreeReaderFactory$StringTreeReader.nextVector(TreeReaderFactory.java:1280) at org.apache.orc.impl.TreeReaderFactory$StructTreeReader.nextVector(TreeReaderFactory.java:1836) at org.apache.orc.impl.TreeReaderFactory$StructTreeReader.nextBatch(TreeReaderFactory.java:1818) at org.apache.orc.impl.RecordReaderImpl.nextBatch(RecordReaderImpl.java:1149)
This is caused due to ORC-54 where schema evolution was done based on field names rather than index. Setting orc.force.positional.evolution will force to do a positional schema evolution but the positional level is hardcoded to 1 (for non acid). Even though it doesn't make sense to have multiple fields with same name in in struct, It breaks the backward compatibly with hive 1.2 / hive2.1.

@shameersss1

This comment has been minimized.

@omalley omalley closed this in 4688240 Aug 20, 2020
omalley pushed a commit that referenced this pull request Aug 21, 2020
…Causes java.io.EOFException

Fixes #505

Signed-off-by: Owen O'Malley <omalley@apache.org>
omalley pushed a commit that referenced this pull request Aug 21, 2020
…Causes java.io.EOFException

Fixes #505

Signed-off-by: Owen O'Malley <omalley@apache.org>
cxzl25 pushed a commit that referenced this pull request Jan 21, 2025
Bumps [org.apache.commons:commons-csv](https://github.com/apache/commons-csv) from 1.12.0 to 1.13.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/apache/commons-csv/blob/master/RELEASE-NOTES.txt">org.apache.commons:commons-csv's changelog</a>.</em></p>
<blockquote>
<p>Apache Commons CSV Version 1.13.0 Release Notes</p>
<p>This document contains the release notes for the 1.13.0 version of Apache Commons CSV.
Commons CSV reads and writes files in variations of the Comma Separated Value (CSV) format.</p>
<p>Commons CSV requires at least Java 8.</p>
<p>The Apache Commons CSV library provides a simple interface for reading and writing CSV files of various types.</p>
<p>This is a feature and maintenance release. Java 8 or later is required.</p>
<p>Changes in this version include:</p>
<h2>New Features</h2>
<ul>
<li>CSV-313:  Add CSVPrinter.getRecordCount(). Thanks to Gary Gregory.</li>
<li>
<pre><code>      Add and use CSVParser.Builder and builder() and deprecate CSVParser constructors. Thanks to Gary Gregory.
</code></pre>
</li>
<li>
<pre><code>      CSVFormat.Builder implements Supplier&lt;CSVFormat&gt;. Thanks to Gary Gregory.
</code></pre>
</li>
<li>
<pre><code>      Deprecate CSVFormat.Builder.build() for get(). Thanks to Gary Gregory.
</code></pre>
</li>
<li>CSV-196:  Track byte position <a href="https://redirect.github.com/apache/commons-csv/issues/502">#502</a>. Thanks to Yuzhan Jiang, Gary Gregory.</li>
</ul>
<h2>Fixed Bugs</h2>
<ul>
<li>CSV-314:  Required OSGi Import-Package version numbers in MANIFEST.MF <a href="https://redirect.github.com/apache/commons-csv/issues/504">#504</a>. Thanks to Gary Gregory.</li>
<li>CSV-314:  CSVParser.nextRecord() should throw CSVException (an IOException subclass) instead of IOException and IllegalStateException, no method signature changes needed. Thanks to Gary Gregory.</li>
</ul>
<h2>Changes</h2>
<ul>
<li>
<pre><code>      Bump org.apache.commons:commons-parent from 76 to 78 [#486](apache/commons-csv#486), [#495](apache/commons-csv#495). Thanks to Gary Gregory, Dependabot.
</code></pre>
</li>
<li>
<pre><code>      Bump org.codehaus.mojo:taglist-maven-plugin from 3.1.0 to 3.2.1 [#493](apache/commons-csv#493). Thanks to Gary Gregory, Dependabot.
</code></pre>
</li>
<li>
<pre><code>      Bump commons-io:commons-io from 2.17.0 to 2.18.0 [#505](apache/commons-csv#505). Thanks to Gary Gregory, Dependabot.
</code></pre>
</li>
<li>
<pre><code>      Bump commons-codec:commons-codec from 1.17.1 to 1.17.2. Thanks to Gary Gregory.
</code></pre>
</li>
<li>
<pre><code>      Bump org.apache.commons:commons-parent from 78 to 79. Thanks to Gary Gregory.
</code></pre>
</li>
</ul>
<p>Historical list of changes: <a href="https://commons.apache.org/proper/commons-csv/changes-report.html">https://commons.apache.org/proper/commons-csv/changes-report.html</a></p>
<p>For complete information on Apache Commons CSV, including instructions on how to submit bug reports,
patches, or suggestions for improvement, see the Apache Commons CSV website:</p>
<p><a href="https://commons.apache.org/proper/commons-csv/">https://commons.apache.org/proper/commons-csv/</a></p>
<p>Download page: <a href="https://commons.apache.org/proper/commons-csv/download_csv.cgi">https://commons.apache.org/proper/commons-csv/download_csv.cgi</a></p>
<p>Have fun!
-Apache Commons CSV team</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/apache/commons-csv/commit/f2f1cffe53cde4b36623403bdc27855cec01fac2"><code>f2f1cff</code></a> Prepare for the next release candidate</li>
<li><a href="https://github.com/apache/commons-csv/commit/732c2f8b1ce031384e63e0594cc16a2945528891"><code>732c2f8</code></a> Prepare for the next release candidate</li>
<li><a href="https://github.com/apache/commons-csv/commit/02b398d33f9c4f0b94f8554586d68394315f9cd5"><code>02b398d</code></a> Add Checstyle UnnecessaryParentheses</li>
<li><a href="https://github.com/apache/commons-csv/commit/947c514bd2183e438d9334aac8b8b506bac6ec11"><code>947c514</code></a> Add Checstyle SuperFinalize</li>
<li><a href="https://github.com/apache/commons-csv/commit/4579bd3be81495965c11c756ae1480b42998c6fa"><code>4579bd3</code></a> Add Checstyle SuperClone</li>
<li><a href="https://github.com/apache/commons-csv/commit/a0ff618877365a6694e8a1e0ede80d0b85df7894"><code>a0ff618</code></a> Add Checstyle StringLiteralEquality</li>
<li><a href="https://github.com/apache/commons-csv/commit/f69526c8f10d8aae6cd094f45ac67132e5d3b6ed"><code>f69526c</code></a> Add Checstyle SimplifyBooleanReturn</li>
<li><a href="https://github.com/apache/commons-csv/commit/81f90443d84112637f967226ebfda99983b65011"><code>81f9044</code></a> Add Checstyle SimplifyBooleanExpression</li>
<li><a href="https://github.com/apache/commons-csv/commit/6afa33cde8039a1233568a1ede5ff0de2cf07e41"><code>6afa33c</code></a> Add Checstyle MultipleVariableDeclarations</li>
<li><a href="https://github.com/apache/commons-csv/commit/114118c00f8e4e918d639c72ada6c213c7ee3d2d"><code>114118c</code></a> Add Checstyle IllegalInstantiation</li>
<li>Additional commits viewable in <a href="https://github.com/apache/commons-csv/compare/rel/commons-csv-1.12.0...rel/commons-csv-1.13.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commons:commons-csv&package-manager=maven&previous-version=1.12.0&new-version=1.13.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Closes #2111 from dependabot[bot]/dependabot/maven/java/org.apache.commons-commons-csv-1.13.0.

Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shaoyun Chen <csy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants