ORC-688: Allow CHAR to be promoted to STRING#572
Merged
dongjoon-hyun merged 1 commit intoapache:masterfrom Nov 27, 2020
Merged
Conversation
Change-Id: I0364faee166f0130abaf5b5ecd749733b9a8fedd
dongjoon-hyun
approved these changes
Nov 27, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pgaref .
pgaref
added a commit
to pgaref/orc
that referenced
this pull request
Nov 30, 2020
### What changes were proposed in this pull request? Enable String conversion from varchar. Currently createStringConvertTreeReader in ConvertTreeReaderFactory is missing that opportunity ### Why are the changes needed? Modify createStringConvertTreeReader to handle char, varchar and string as part of the same group. ### How was this patch tested? TestSchemaEvolution.testCharToStringEvolution (cherry picked from commit 48cba3b)
pgaref
added a commit
to pgaref/orc
that referenced
this pull request
Nov 30, 2020
### What changes were proposed in this pull request? Enable String conversion from varchar. Currently createStringConvertTreeReader in ConvertTreeReaderFactory is missing that opportunity ### Why are the changes needed? Modify createStringConvertTreeReader to handle char, varchar and string as part of the same group. ### How was this patch tested? TestSchemaEvolution.testCharToStringEvolution (cherry picked from commit 48cba3b) Change-Id: Ibf1daa60665784c21dc7d25066d85e1b7193b155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable String conversion from varchar.
Currently createStringConvertTreeReader in ConvertTreeReaderFactory is missing that opportunity
Why are the changes needed?
Modify createStringConvertTreeReader to handle char, varchar and string as part of the same group.
How was this patch tested?
TestSchemaEvolution.testCharToStringEvolution