ORC-709: FIX Boolean to StringGroup schema evolution#594
Merged
dongjoon-hyun merged 3 commits intoapache:masterfrom Dec 30, 2020
Merged
ORC-709: FIX Boolean to StringGroup schema evolution#594dongjoon-hyun merged 3 commits intoapache:masterfrom
dongjoon-hyun merged 3 commits intoapache:masterfrom
Conversation
java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java
Outdated
Show resolved
Hide resolved
java/core/src/test/org/apache/orc/impl/TestSchemaEvolution.java
Outdated
Show resolved
Hide resolved
java/core/src/test/org/apache/orc/impl/TestSchemaEvolution.java
Outdated
Show resolved
Hide resolved
java/core/src/test/org/apache/orc/impl/TestSchemaEvolution.java
Outdated
Show resolved
Hide resolved
java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java
Outdated
Show resolved
Hide resolved
Member
|
Please update #595 together. |
dongjoon-hyun
approved these changes
Dec 30, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pgaref .
pgaref
added a commit
that referenced
this pull request
Dec 30, 2020
### What changes were proposed in this pull request? Special ConvertTreeReader for Boolean using StringGroupFromAnyIntegerTreeReader for String/Char/Varchar types ### Why are the changes needed? Properly handle Boolean to String/Char/Varchar conversions ### How was this patch tested? TestSchemaEvolution.testBooleanToStringEvolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Special ConvertTreeReader for Boolean using StringGroupFromAnyIntegerTreeReader for String/Char/Varchar types
Why are the changes needed?
Properly handle Boolean to String/Char/Varchar conversions
How was this patch tested?
TestSchemaEvolution.testBooleanToStringEvolution