Skip to content

ORC-753: [C++] Clear stream state of ColumnReader after seek #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xndai merged 1 commit into from
Feb 27, 2021
Merged

ORC-753: [C++] Clear stream state of ColumnReader after seek #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions c++/src/ColumnReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,9 @@ namespace orc {
std::unordered_map<uint64_t, PositionProvider>& positions) {
ColumnReader::seekToRowGroup(positions);
inputStream->seek(positions.at(columnId));
// clear buffer state after seek
bufferEnd = nullptr;
bufferPointer = nullptr;
}

class StringDictionaryColumnReader: public ColumnReader {
Expand Down Expand Up @@ -838,6 +841,9 @@ namespace orc {
ColumnReader::seekToRowGroup(positions);
blobStream->seek(positions.at(columnId));
lengthRle->seek(positions.at(columnId));
// clear buffer state after seek
lastBuffer = nullptr;
lastBufferLength = 0;
}

class StructColumnReader: public ColumnReader {
Expand Down Expand Up @@ -1553,6 +1559,9 @@ namespace orc {
ColumnReader::seekToRowGroup(positions);
valueStream->seek(positions.at(columnId));
scaleDecoder->seek(positions.at(columnId));
// clear buffer state after seek
buffer = nullptr;
bufferEnd = nullptr;
}

class Decimal128ColumnReader: public Decimal64ColumnReader {
Expand Down