ORC-691: Remove unused Snapcraft-related code #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hi, @omalley , @wgtmac , @pgaref , @williamhyun . WDYT about this removal? |
Member
|
+1 LGTM |
Member
Author
|
Thank you, @williamhyun ! |
Member
|
Just curious if we can get the user activity from snapcraft. If it is rarely used there, we are confident to deprecate the support. |
Member
Author
|
Thank you for review. Ya, I'm also wondering if that is used until now, @wgtmac . @omalley may be able to get some statistics as the owner of that Snapcraft store. BTW, it's already not supported for three years (August 2018). To be safe, we may just want to remove this from our repo and keep |
Member
Author
|
Thank you, @williamhyun and @wgtmac . |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 14, 2021
### What changes were proposed in this pull request? This PR aims to remove unused `Snapcraft`-related code from Apache ORC repository at Apache ORC 1.8.0. ### Why are the changes needed? The last release was Apache ORC 1.5.2 on `7 August 2018`. We had better remove this from Apache ORC repo and Snapstore officially to reduce the confusion. - https://snapcraft.io/orc ### How was this patch tested? N/A (This is a removal of unused code) (cherry picked from commit 0716814) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove unused
Snapcraft-related code from Apache ORC repository at Apache ORC 1.8.0.Why are the changes needed?
The last release was Apache ORC 1.5.2 on
7 August 2018. We had better remove this from Apache ORC repo and Snapstore officially to reduce the confusion.How was this patch tested?
N/A (This is a removal of unused code)