ORC-911: Remove janino dependency in favor of Spark's transitive dependency#817
Merged
williamhyun merged 2 commits intoapache:mainfrom Aug 6, 2021
dongjoon-hyun:ORC-911
Merged
ORC-911: Remove janino dependency in favor of Spark's transitive dependency#817williamhyun merged 2 commits intoapache:mainfrom dongjoon-hyun:ORC-911
williamhyun merged 2 commits intoapache:mainfrom
dongjoon-hyun:ORC-911
Conversation
Member
Author
|
cc @pgaref and @williamhyun |
Member
Author
|
This will clean up the mismatched dependencies and suppress |
williamhyun
approved these changes
Aug 6, 2021
Member
williamhyun
left a comment
williamhyun
left a comment
There was a problem hiding this comment.
+1 LGTM, I will merge this and look at ORC-912 after.
Member
Author
|
Thank you so much, @williamhyun ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 6, 2021
…ndency (#817) ### What changes were proposed in this pull request? This PR aims to remove `janino` runtime dependency from `bench` module in favor of Spark's transitive dependency. ### Why are the changes needed? We should not override it. Spark uses a specific version because some latest Janino has bugs. ### How was this patch tested? Pass the CIs. Closes #799 and #804 . (cherry picked from commit 5c6008d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
janinoruntime dependency frombenchmodule in favor of Spark's transitive dependency.Why are the changes needed?
We should not override it. Spark uses a specific version because some latest Janino has bugs.
How was this patch tested?
Pass the CIs.
Closes #799 and #804 .