ORC-913: Support data/format/compress options in Spark benchmark#825
Merged
dongjoon-hyun merged 1 commit intoapache:mainfrom Aug 7, 2021
Merged
ORC-913: Support data/format/compress options in Spark benchmark#825dongjoon-hyun merged 1 commit intoapache:mainfrom
dongjoon-hyun merged 1 commit intoapache:mainfrom
Conversation
dongjoon-hyun
approved these changes
Aug 7, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @williamhyun .
I saw the limitation, but it works for me.
This extension does not appear in -h option, however, it will work.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 7, 2021
### What changes were proposed in this pull request? This PR aims to support data/format/compress options in Spark benchmark. ### Why are the changes needed? This will make Spark benchmark more controllable. This extension does not appear in -h option, however, it will work. ### How was this patch tested? Manual ``` java -jar spark/target/orc-benchmarks-spark-1.8.0-SNAPSHOT.jar spark data -d sales -c snappy -f orc ``` (cherry picked from commit 4f089c2) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support data/format/compress options in Spark benchmark.
Why are the changes needed?
This will make Spark benchmark more controllable.
This extension does not appear in -h option, however, it will work.
How was this patch tested?
Manual