ORC-971: [C++] Fix LESS_THAN_EQUALS doesn't handle the case when minValue equals to maxValue#883
Merged
dongjoon-hyun merged 1 commit intoapache:mainfrom Aug 26, 2021
Merged
Conversation
…alue equals to maxValue
dongjoon-hyun
approved these changes
Aug 26, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @stiga-huang and @wgtmac .
Merged to main/1.7
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 26, 2021
…alue equals to maxValue (#883) ### What changes were proposed in this pull request? When evaluating the LESS_THAN_EQUALS predicates, the case that has identical minValue and maxValue is not handled correctly. E.g. predicate "x <= 15" on a range [15, 15] should get YES or YES_NULL results. But what we currently get is YES_NO or YES_NO_NULL. This patch fixes evaluatePredicateRange() to handle this case. ### Why are the changes needed? Described above. ### How was this patch tested? Added unit tests in c++/test/TestPredicateLeaf.cc (cherry picked from commit 1438ef6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When evaluating the LESS_THAN_EQUALS predicates, the case that has identical minValue and maxValue is not handled correctly. E.g. predicate "x <= 15" on a range [15, 15] should get YES or YES_NULL results. But what we currently get is YES_NO or YES_NO_NULL. This patch fixes evaluatePredicateRange() to handle this case.
Why are the changes needed?
Described above.
How was this patch tested?
Added unit tests in c++/test/TestPredicateLeaf.cc