ORC-974: Remove Text Key from StringRedBlackTree#885
ORC-974: Remove Text Key from StringRedBlackTree#885belugabehr wants to merge 2 commits intoapache:mainfrom
Conversation
| */ | ||
| private boolean add(int node, boolean fromLeft, int parent, | ||
| int grandparent, int greatGrandparent) { | ||
| private boolean add(int node, boolean fromLeft, int parent, int grandparent, |
dongjoon-hyun
changed the title
| */ | ||
| protected boolean add() { | ||
| add(root, false, NULL, NULL, NULL); | ||
| protected boolean doAdd(byte[] bytes, int offset, int length) { |
There was a problem hiding this comment.
Is this renamed to avoid conflicts?
There was a problem hiding this comment.
Yes. There is already a public method with the same name/signature.
| newKey.set(bytes, offset, length); | ||
| return addNewKey(); | ||
| // if the newKey is actually new, add it to our byteArray and store the offset & length | ||
| if (doAdd(bytes, offset, length)) { |
There was a problem hiding this comment.
Is this renamed to avoid conflicts?
@dongjoon-hyun, should be here to avoid recursive calls.
There was a problem hiding this comment.
Ya, that was my question.
There was a problem hiding this comment.
Yes. There is already a public method with the same name/signature.
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
3 participants
What changes were proposed in this pull request?
Remove the dependency on Hadoop's Text class from RedBlackTree. This has the added benefit of skipping the step where the incoming bytes are copied into the Text class.
Why are the changes needed?
Allows for removing dependency on Hadoop later; improve performance by removing copy.
How was this patch tested?
No functionality change. Using existing unit tests.