HDDS-11632. Publish images to GitHub container repo#32
Merged
adoroszlai merged 2 commits intoapache:latestfrom Nov 12, 2024
Merged
HDDS-11632. Publish images to GitHub container repo#32adoroszlai merged 2 commits intoapache:latestfrom
adoroszlai merged 2 commits intoapache:latestfrom
Conversation
Contributor
Author
smengcl
approved these changes
Nov 9, 2024
smengcl
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai . just one nit. feel free to merge this when infra issue is resolved.
Co-authored-by: Siyao Meng <50227127+smengcl@users.noreply.github.com>
Contributor
Author
|
Thanks @smengcl for the review. Infra issue is fixed. |
adoroszlai
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 7ef3e0b)
adoroszlai
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 7ef3e0b)
adoroszlai
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 7ef3e0b)
adoroszlai
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 7ef3e0b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Workflow to build and publish multi-platform
ozoneDocker image to GitHub Container Registry and Docker Hub.ozone-X.Y: the image is also published with Docker tagX.Y. This matches current Docker Hub automated build rules.ozone-docker-runner, push to Docker Hub is optional, only performed if credentials are available.This PR is targeted at
latest, which is likemainfor this repo. After merge, we'll need to cherry-pick it to version-specific branches where we would like the workflow to be used. We'll also need to ask Infra to disable the automated build at Docker Hub.https://issues.apache.org/jira/browse/HDDS-11632
How was this patch tested?
Push to branches:
HDDS-11632(workflow, image).ozone-test(workflow, image).ozone-test-with-dhafter adding Docker Hub credentials to the repo (workflow, image at ghcr.io and hub.docker.com)(Note that the same commit was pushed to all branches, so tags
testandtest-with-dhrefer to the same image.)