Skip to content

HDDS-11632. Publish images to GitHub container repo#32

Merged
adoroszlai merged 2 commits intoapache:latestfrom
adoroszlai:HDDS-11632
Nov 12, 2024
Merged

HDDS-11632. Publish images to GitHub container repo#32
adoroszlai merged 2 commits intoapache:latestfrom
adoroszlai:HDDS-11632

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Nov 7, 2024

What changes were proposed in this pull request?

Workflow to build and publish multi-platform ozone Docker image to GitHub Container Registry and Docker Hub.

  • Pull request: image is built, but not published
  • Push: image is built and published by commit SHA.
  • Push to branch ozone-X.Y: the image is also published with Docker tag X.Y. This matches current Docker Hub automated build rules.
  • Similarly to ozone-docker-runner, push to Docker Hub is optional, only performed if credentials are available.

This PR is targeted at latest, which is like main for this repo. After merge, we'll need to cherry-pick it to version-specific branches where we would like the workflow to be used. We'll also need to ask Infra to disable the automated build at Docker Hub.

https://issues.apache.org/jira/browse/HDDS-11632

How was this patch tested?

Push to branches:

(Note that the same commit was pushed to all branches, so tags test and test-with-dh refer to the same image.)

@adoroszlai adoroszlai self-assigned this Nov 7, 2024
@adoroszlai adoroszlai changed the base branch from 0.3.0 to latest November 7, 2024 20:47
@adoroszlai
Copy link
Contributor Author

@errose28 @smengcl please take a look

Even if approved, I'll wait for response on INFRA-26258 before merging this.

Copy link

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai . just one nit. feel free to merge this when infra issue is resolved.

Co-authored-by: Siyao Meng <50227127+smengcl@users.noreply.github.com>
@adoroszlai adoroszlai merged commit 7ef3e0b into apache:latest Nov 12, 2024
@adoroszlai adoroszlai deleted the HDDS-11632 branch November 12, 2024 09:56
@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review. Infra issue is fixed.

adoroszlai added a commit that referenced this pull request Nov 12, 2024
adoroszlai added a commit that referenced this pull request Nov 12, 2024
adoroszlai added a commit that referenced this pull request Nov 12, 2024
adoroszlai added a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants