HDDS-12538. Update README/CONTRIBUTING in ozone-docker#43
Merged
adoroszlai merged 2 commits intoapache:latestfrom Mar 21, 2025
Merged
HDDS-12538. Update README/CONTRIBUTING in ozone-docker#43adoroszlai merged 2 commits intoapache:latestfrom
adoroszlai merged 2 commits intoapache:latestfrom
Conversation
Contributor
Author
|
@octachoron would you like to review this? |
errose28
approved these changes
Mar 20, 2025
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
LGTM thanks for adding this @adoroszlai.
octachoron
suggested changes
Mar 21, 2025
octachoron
left a comment
octachoron
left a comment
There was a problem hiding this comment.
Thank you @adoroszlai, this is really helpful, especially to a new contributor.
There is one point where a change was necessary to successfully try the commands. Otherwise, looks good to me too.
CONTRIBUTING.md
Outdated
|
|
||
| ### Testing | ||
|
|
||
| The image can be tested locally with the sample Docker Compose definition in this repo, by setting `OZONE_VERSION`: |
There was a problem hiding this comment.
I think it is OZONE_IMAGE_VERSION that influences this. It seemed like that when trying the commands as well.
octachoron
approved these changes
Mar 21, 2025
Contributor
Author
|
Thanks @errose28, @octachoron for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update README.md and add CONTRIBUTING.md, similar to the ones added for other Docker image repos in HDDS-12441.
https://issues.apache.org/jira/browse/HDDS-12538
How was this patch tested?
👀
Commands tested manually.