HDDS-5081. Fix key put implementation#2
Closed
adoroszlai wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
Will recreate once code import is sorted out. |
cxorm
approved these changes
Apr 11, 2021
| ozoneClient := api.CreateOzoneClient(c.GlobalString("om")) | ||
| address := OzoneObjectAddressFromString(c.Args().Get(0)) | ||
| f, err := os.Open("/tmp/asd") | ||
| f, err := os.Open(c.Args().Get(1) |
Member
There was a problem hiding this comment.
This change improves flexibility IMHO.
Thanks @adoroszlai for the contribution,
+1 (Let's merge it after importing POC code.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace hard-coded
/tmp/asdlocal file with command-line argument forkey putoperation.https://issues.apache.org/jira/browse/HDDS-5081
How was this patch tested?
NOTE: this PR is intentionally created with a compile error.