Skip to content

HDDS-5340. Put github PR template of ozone-go#9

Merged
kaijchen merged 1 commit intoapache:masterfrom
cxorm:HDDS-5340
Sep 2, 2022
Merged

HDDS-5340. Put github PR template of ozone-go#9
kaijchen merged 1 commit intoapache:masterfrom
cxorm:HDDS-5340

Conversation

@cxorm
Copy link
Member

@cxorm cxorm commented Jun 12, 2021

What changes were proposed in this pull request ?

Put github PR template of ozone-go.

What is the link to the Apache JIRA ?

https://issues.apache.org/jira/browse/HDDS-5340

How was this patch tested ?

I think we could not add test here if you don't mind ; )

@cxorm
Copy link
Member Author

cxorm commented Jun 12, 2021

This PR is to address the following scene :
In the Apache Ozone repo, the jira number in commit history bar is linked to jira,
but in the Apache Ozone-go repo is not.

ozone history bar
ozone-go history bar

First I went to the asf yaml and not found something related. (Feel free to correct me if I miss anything), then I went through many Apache Project and I found those repo with this feature having pull_request_template.md.

So I guess it is the reason, let's try it.

@cxorm cxorm self-assigned this Jun 12, 2021
@sky76093016
Copy link

I have also observed this problem before, thank @cxorm for fixing it!

@kaijchen
Copy link
Member

kaijchen commented Sep 2, 2022

This PR is to address the following scene :
In the Apache Ozone repo, the jira number in commit history bar is linked to jira,
but in the Apache Ozone-go repo is not.

I don't think this is related to the PR template.
But the PR template looks good.
Let's merge it.

@kaijchen kaijchen merged commit 06a9ffa into apache:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants