Skip to content

HDDS-13474. Support abort incomplete multipart upload action#10052

Merged
ivandika3 merged 21 commits intoapache:HDDS-8342from
YutaLin:HDDS-13474_Support_AbortIncompleteMultipartUpload_Action
May 2, 2026
Merged

HDDS-13474. Support abort incomplete multipart upload action#10052
ivandika3 merged 21 commits intoapache:HDDS-8342from
YutaLin:HDDS-13474_Support_AbortIncompleteMultipartUpload_Action

Conversation

@YutaLin
Copy link
Copy Markdown
Contributor

@YutaLin YutaLin commented Apr 6, 2026

What changes were proposed in this pull request?

Support AbortIncompleteMultipartUpload action

Please describe your PR in detail:
configure a lifecycle rule by using the AbortIncompleteMultipartUpload action to minimize storage costs.

What is the link to the Apache JIRA

https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpu-abort-incomplete-mpu-lifecycle-config.html

How was this patch tested?

Add unit tests and xml tests
CI Action (https://github.com/YutaLin/ozone/actions/runs/24017470716)

@spacemonkd spacemonkd changed the title Hdds 13474 support abort incomplete multipart upload action HDDS-13474. Support abort incomplete multipart upload action Apr 6, 2026
@spacemonkd spacemonkd added the s3 S3 Gateway label Apr 6, 2026
@spacemonkd spacemonkd requested a review from ivandika3 April 6, 2026 16:09
Copy link
Copy Markdown
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YutaLin Thanks for the new feature. Left some comments.

@ivandika3 ivandika3 added the s3-lifecycle HDDS-8342 label Apr 9, 2026
@YutaLin YutaLin force-pushed the HDDS-13474_Support_AbortIncompleteMultipartUpload_Action branch from fc87aa5 to 0820358 Compare April 24, 2026 03:39
@YutaLin YutaLin force-pushed the HDDS-13474_Support_AbortIncompleteMultipartUpload_Action branch from 0820358 to f3ad94c Compare April 24, 2026 11:59
@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented Apr 25, 2026

Hi @ivandika3,
thanks for the review, i've made some changes based on your feedback!

Copy link
Copy Markdown
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YutaLin for the update. Left some comments.

Kindly help to add tests on the E2E flow that verify that incomplete multipart uploads are actually aborted.

@ivandika3 ivandika3 requested a review from ChenSammi April 26, 2026 04:33
@YutaLin YutaLin force-pushed the HDDS-13474_Support_AbortIncompleteMultipartUpload_Action branch from dd102e9 to e5e5210 Compare April 28, 2026 20:20
@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented Apr 29, 2026

HI @ivandika3, appreciate the review, i've add some e2e tests and cover mpu!

Copy link
Copy Markdown
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YutaLin for continued update. Overall LGTM. Just left one more comment.

@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented May 1, 2026

Hi @ivandika3, i've fix the filter logic and migrate the e2e tests, please help me review again, thanks!

@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented May 1, 2026

@YutaLin YutaLin requested a review from ivandika3 May 1, 2026 06:05
Copy link
Copy Markdown
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YutaLin for the continued effort. LGTM +1.

I'll merge this after the CI is green.

@YutaLin
Copy link
Copy Markdown
Contributor Author

YutaLin commented May 2, 2026

HI @ivandika3, i saw the CI is fail due to method retry in testlib.sh, so i merge latest HDDS-8342. Can you help me trigger CI again, thanks!

@ivandika3 ivandika3 merged commit f3c6ba4 into apache:HDDS-8342 May 2, 2026
130 of 133 checks passed
@ivandika3
Copy link
Copy Markdown
Contributor

Thanks @YutaLin for the patch.

@YutaLin YutaLin deleted the HDDS-13474_Support_AbortIncompleteMultipartUpload_Action branch May 2, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3-lifecycle HDDS-8342 s3 S3 Gateway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants