HDDS-14756. Implement delegation and auditing for BucketOperationHandler#10057
Merged
peterxcli merged 1 commit intoapache:masterfrom Apr 9, 2026
Merged
HDDS-14756. Implement delegation and auditing for BucketOperationHandler#10057peterxcli merged 1 commit intoapache:masterfrom
peterxcli merged 1 commit intoapache:masterfrom
Conversation
ivandika3
approved these changes
Apr 9, 2026
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks for the patch, now both object and bucket endpoint seem to have been fully refactored. LGTM +1.
Member
|
Thanks @adoroszlai for the patch, @ivandika3 for the review! |
Contributor
Author
|
Thanks @ivandika3, @peterxcli for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BucketOperationHandlerfor auditing and chain-of-responsibility (like similar implementations ofObjectOperationHandler).BucketEndpoint.listMultipartUploadsinto its own handler class (ListMultipartUploadsHandler).BucketEndpointalso be aBucketOperationHandler(at the end of the chain).BucketEndpoint.handleGetRequestto keep line count below 150 (avoid the need for suppression).https://issues.apache.org/jira/browse/HDDS-14756
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/24078478672