HDDS-15003. Inline EndpointBase#createS3Bucket/deleteS3Bucket#10060
Merged
ivandika3 merged 1 commit intoapache:masterfrom Apr 10, 2026
Merged
HDDS-15003. Inline EndpointBase#createS3Bucket/deleteS3Bucket#10060ivandika3 merged 1 commit intoapache:masterfrom
ivandika3 merged 1 commit intoapache:masterfrom
Conversation
ivandika3
approved these changes
Apr 10, 2026
Contributor
ivandika3
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai , LGTM +1.
Contributor
|
Thanks @adoroszlai for the patch and @peterxcli for the review. |
Contributor
Author
|
Thanks @ivandika3, @peterxcli for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BucketEndpointis responsible for convertingOMExceptiontoOS3Exception, but bucket management methods inherited fromEndpointBasealso do it for some result codes. These are called from inner handler methods (within audited block). This causes audit log to show the wrong exception (OS3Exception) in some cases. This change is the first step towards fixing that, follow-up will handle remaininggetBucketusage.EndpointBase#createS3Bucketand#deleteS3BucketintoBucketCrudHandlerEndpointBase#getBucket(OzoneVolume, String)EndpointBase#getBucket(String)OzoneBucketStub#isEmptyto reduce extra logic related to "emptiness" inObjectStoreStub(both of these objects are used only in unit tests). Previous logic allowedTestS3GatewayMetrics#testDeleteBucketSuccessto delete a non-empty bucket because "non-empty" flag was not set.https://issues.apache.org/jira/browse/HDDS-15003
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/24191772810