HDDS-15109. Extract rename test cases to OzoneFileSystemTests#10120
Merged
adoroszlai merged 2 commits intoapache:masterfrom May 7, 2026
Merged
HDDS-15109. Extract rename test cases to OzoneFileSystemTests#10120adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
added
test
code-cleanup
Russole
reviewed
Apr 26, 2026
Comment on lines
+1744
to
+1747
| void verifyRenameFile(Path workDir, Path expectedDest) throws IOException { | ||
| FileStatus[] fStatus = getFs().listStatus(workDir); | ||
| assertEquals(1, fStatus.length, "Renamed failed"); | ||
| } |
Contributor
There was a problem hiding this comment.
Could we also verify expectedDest here, or add a short comment explaining why RootedOzoneFileSystem only checks the number of entries? Since expectedDest is passed from the base helper, skipping the path assertion looks a bit unclear to me.
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @len548 , left few minor comments
sreejasahithi
approved these changes
May 4, 2026
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @len548, overall LGTM
Contributor
Author
|
Hi @Russole, can you review this again when you have time? Thanks! |
Contributor
|
Thanks @len548 for the patch, @Russole, @sreejasahithi for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are duplicates of rename tests between
AbstractOzoneFileSystemTestandAbstractRootedOzoneFileSystemTest.testRenameFiletestRenameFileToDirtestRenameToParentDirtestRenameDirToItsOwnSubDirtestRenameDestinationParentDoesntExist(O3FS) /testRenameDestinationParentDoesNotExist(OFS) – same test, different spelling.This PR moved shared logic of these tests to OzoneFileSystemTestBase and also introduced a helper method
pathUnderFsRoot(String p)which centralizes the difference “fs.getUri().toString() + path” (O3FS) vs "getBucketPath() + path" (OFS) by template method pattern.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15109
How was this patch tested?
CI pass: https://github.com/len548/ozone/actions/runs/24833798824