HDDS-15108. Remove duplicate keys from ozone-default.xml#10121
Merged
sarvekshayr merged 3 commits intoapache:masterfrom Apr 26, 2026
Merged
HDDS-15108. Remove duplicate keys from ozone-default.xml#10121sarvekshayr merged 3 commits intoapache:masterfrom
sarvekshayr merged 3 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
ozone.scm.block.deletion.per.dn.distribution.factor is defined twice consecutively with identical content. Since this PR is already cleaning up ozone-default.xml, could you remove the duplicate entry here as well?
Russole
approved these changes
Apr 25, 2026
Contributor
Russole
left a comment
Russole
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for working on this. LGTM!
sarvekshayr
approved these changes
Apr 26, 2026
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Great catch! Thanks @adoroszlai for the fix. This resolves the multiple unnecessary commits seen in the ozone-site automated config PR.
LGTM.
Contributor
|
Thanks @adoroszlai for the patch, @sreejasahithi and @Russole for the review. |
Contributor
Author
|
Thanks @Russole, @sarvekshayr, @sreejasahithi for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some config properties are duplicated between
ozone-default.xmland classes annotated with@Config. This causes the generated documentation to flip-flop between the different defaults/descriptions/tags (example: apache/ozone-site@57d92be).This change:
xml_to_md.pyto catch duplicate propertiesozone-default.xmlTestOzoneConfigurationFieldsby moving some constants out of the classes being checkedBasicRootedOzoneClientAdapterImplto storeOzoneClientConfiginstead of creating it for eachgetFileChecksumcallhadoop.http.idle_timeout.msfromhttpfs-default.xml(duplicated fromozone-default.xml)https://issues.apache.org/jira/browse/HDDS-15108
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/24883493975