HDDS-15104. Refactor code related to container space management.#10124
Merged
ashishkumar50 merged 5 commits intoapache:masterfrom Apr 28, 2026
Merged
HDDS-15104. Refactor code related to container space management.#10124ashishkumar50 merged 5 commits intoapache:masterfrom
ashishkumar50 merged 5 commits intoapache:masterfrom
Conversation
szetszwo
reviewed
Apr 25, 2026
Contributor
|
@ashishkumar50 , thanks for working on this! Please see the comment inlined in the previous comment and also https://issues.apache.org/jira/secure/attachment/13081849/10124_review.patch |
Contributor
Author
|
@szetszwo thanks for the suggestion, updated it. |
Contributor
Author
Removed getBucket and related code as we don't need pipeline in pendingContaierTracker. It will be called via pipelineManager. |
szetszwo
approved these changes
Apr 27, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
rakeshadr
approved these changes
Apr 28, 2026
Contributor
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
+1 refactoring looks good to me
Contributor
Author
|
@szetszwo @rakeshadr, Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor below code:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15104
How was this patch tested?
Updated existing test