HDDS-15213. Use common commit output for stream outputs#10224
Open
peterxcli wants to merge 1 commit intoapache:masterfrom
Open
HDDS-15213. Use common commit output for stream outputs#10224peterxcli wants to merge 1 commit intoapache:masterfrom
peterxcli wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
commented
May 9, 2026
Comment on lines
+146
to
+164
| public void testPartUploadWithStandardIAAndContentMD5() throws Exception { | ||
| when(headers.getHeaderString(STORAGE_CLASS_HEADER)) | ||
| .thenReturn(S3StorageType.STANDARD_IA.name(), (String)null); | ||
| String content = "Multipart Upload Part"; | ||
| byte[] contentBytes = content.getBytes(StandardCharsets.UTF_8); | ||
| byte[] md5Bytes = MessageDigest.getInstance("MD5").digest(contentBytes); | ||
| String md5Base64 = Base64.getEncoder().encodeToString(md5Bytes); | ||
| when(headers.getHeaderString("Content-MD5")).thenReturn(md5Base64); | ||
|
|
||
| String keyName = UUID.randomUUID().toString(); | ||
| String uploadID = initiateMultipartUpload(rest, OzoneConsts.S3_BUCKET, keyName); | ||
|
|
||
| try (Response response = put(rest, OzoneConsts.S3_BUCKET, keyName, 1, | ||
| uploadID, content)) { | ||
| assertNotNull(response.getHeaderString(OzoneConsts.ETAG)); | ||
| assertEquals(200, response.getStatus()); | ||
| } | ||
| assertContentLength(uploadID, keyName, content.length()); | ||
| } |
Member
Author
There was a problem hiding this comment.
this test case would fail on master with:
NullPointerException: Cannot invoke
"org.apache.hadoop.ozone.client.io.KeyDataStreamOutput.setPreCommits(java.util.List)"
because the return value of
"OzoneDataStreamOutput.getKeyDataStreamOutput()" is null
at ObjectEndpointStreaming.createMultipartKey(ObjectEndpointStreaming.java:243)
peterxcli
requested review from
Gargi-jais11,
Russole,
adoroszlai,
ivandika3 and
xichen01
Member
Author
|
cc @yandrey321, @hevinhsu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce a new
KeyCommitOutputinterface to unify commit-time behaviors for key output implementations in the Ozone client, and refactors related classes to use this interface. It also simplifies the handling of pre-commit hooks and improves multipart upload handling, especially for EC mpu.Testing:
the
InstanceOfcheck refactor is similar to #9370What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15213
How was this patch tested?
IT/UT