HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler

[YutaLin]

What changes were proposed in this pull request?

CertificateStore and RootCARotationHandler have Replicate.InvocationType.CLIENT methods. We need to add a new method ScmInvoker.invokeReplicateClient(..), which is similar to SCMHAInvocationHandler.invokeRatisClient(..).

• Add CertificationStoreInvoker, RootCARotationHandlerInvoker
• Use scminvoker certifcate store and root CA rotation instead
• Update TestSCMCertStore

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15190

How was this patch tested?

CI (https://github.com/YutaLin/ozone/actions/runs/25616356321)

[Russole]

Thanks @YutaLin for the patch. Overall LGTM.

One small suggestion: RootCARotationHandlerInvoker is marked as generated code, but the method order in newProxy() differs from ScmInvokerCodeGenerator output. It would be better to keep the generated order for consistency with the other ScmInvoker implementations.

I generated the equivalent change here:
Russole@b0decc7

This is not a functional change, only method ordering plus the generator main method in RootCARotationHandler.

[YutaLin]

Thanks @Russole for the review!

[Russole]

Thanks @YutaLin. Could you also apply this small consistency update before merge?

Since RootCARotationHandlerInvoker is marked as generated code, I think it is better to keep it aligned with ScmInvokerCodeGenerator output.

[adoroszlai]

One small suggestion: RootCARotationHandlerInvoker is marked as generated code, but the method order in newProxy() differs from ScmInvokerCodeGenerator output. It would be better to keep the generated order for consistency with the other ScmInvoker implementations.

Agreed.

@Russole if you ask for changes please don't trigger CI, since it will have to be re-run after patch is updated

[Russole]

Thanks @adoroszlai, noted. I’ll avoid triggering CI when requesting changes.

[YutaLin]

HI @Russole @adoroszlai
Thanks for the review, I've made some change.
FYI, I don't add ScmInvokerCodeGenerator.generate in CertificateStore because it's in different module, and it will have circular dependency If i import the module. It's also not a big problem since we only use it to generate Invoker.

[szetszwo]

+1 the change looks good.

[Russole]

Thanks @YutaLin for working on this. LGTM!

[adoroszlai]

Thanks @YutaLin for the patch, @Russole, @szetszwo for the review.

[YutaLin]

Thanks @adoroszlai for the merge!