HDDS-15232. Reduce duplication in ozonesecure env#10239
Conversation
priyeshkaratha
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the patch. Please check the inline comment?
| - ../_keytabs:/etc/security/keytabs | ||
| - ./krb5.conf:/etc/krb5.conf | ||
| env_file: | ||
| - docker-config |
There was a problem hiding this comment.
Is it recommended ./docker-config or docker-config?
There was a problem hiding this comment.
./ is required for volumes in the current directory ("to avoid ambiguities with named volumes, relative paths should always begin with . or .."). There is no such ambiguity with env_file, so the form docker-config is recommended for simplicity.
dombizita
left a comment
There was a problem hiding this comment.
Thanks for working on this @adoroszlai, I have two small questions about merging ozonesecure-mr into ozonesecure, otherwise it looks good to me!
dombizita
left a comment
There was a problem hiding this comment.
Thank you for the answers, all makes sense!
|
Thanks for working on this @adoroszlai, thank you for the review @priyeshkaratha! |
|
Thanks @dombizita, @priyeshkaratha for the review. |
What changes were proposed in this pull request?
Reduce duplication in non-HA secure docker-compose environments:
ozonesecure-mrintoozonesecureozonesecurehttps://issues.apache.org/jira/browse/HDDS-15232
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/25675964314
ozonesecure/test-hadoop.shpassed in:https://github.com/adoroszlai/ozone/actions/runs/25675964314/job/75379224808