HDDS-14944. Implement rewrite logic for Iceberg's manifest files for path migration#10243
Merged
Merged
Conversation
Contributor
Author
|
@ashishkumar50 could you please review this patch. |
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
@sreejasahithi Thanks for the patch, please find the comments inlined.
ashishkumar50
approved these changes
May 18, 2026
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
@sreejasahithi Thanks for updating patch, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch implements the rewrite of selected manifest files of the Iceberg table by processing each manifest based on its type (data or delete) and with help of Iceberg's RewriteTablePathUtil we can change from sourcePrefix to targetPrefix for each data file absolute path mentioned in the manifest file and then add rewritten manifest file to a staging location.
What is the link to the Apache JIRA
HDDS-14944
How was this patch tested?
Updated existing tests
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/25675856864