HDDS-15243. Remove unused GenericRefreshProtocol, RefreshCallQueueProtocol#10244
Merged
Conversation
adoroszlai
added
the
code-cleanup
Contributor
|
@adoroszlai How about we raise a ticket to implement refresh call queue capabilities instead? It's a good way to prioritize or deprioritize a user / group priority without restarting OM. |
Contributor
Author
I would like to remove it first, to reduce unused/untested code in 2.2.0. It will be easy to restore it from git history, if/when work on the implementation is started. Also, bigger part of removed code is |
Contributor
Author
|
Thanks @ivandika3 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unused code from forked Hadoop RPC (part 1):
GenericRefreshProtocol,RefreshCallQueueProtocoland related code.https://issues.apache.org/jira/browse/HDDS-15243
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/25713574105