HDDS-15166. Increased cleanup interval and purged partial reports during cleanup.#10250
Open
SaketaChalamchala wants to merge 4 commits into
Open
HDDS-15166. Increased cleanup interval and purged partial reports during cleanup.#10250SaketaChalamchala wants to merge 4 commits into
SaketaChalamchala wants to merge 4 commits into
Conversation
sadanand48
reviewed
May 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts snapshot diff cleanup behavior so failed/rejected/cancelled jobs remain queryable longer and report cleanup also removes partial reports for purged jobs with zero recorded diff entries.
Changes:
- Increases the default snapshot diff cleanup interval from 1 minute to 60 minutes.
- Updates cleanup logic to delete report ranges for every purged job, regardless of
totalDiffEntries. - Adds a unit test covering partial report cleanup for a zero-entry failed job.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDiffCleanupService.java |
Updates cleanup accounting/logging and removes the totalDiffEntries > 0 guard before report range deletion. |
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestSnapshotDiffCleanupService.java |
Adds cleanup coverage for zero-entry purged jobs and drops test column families during teardown. |
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java |
Changes the default cleanup interval constant to 60 minutes. |
hadoop-hdds/common/src/main/resources/ozone-default.xml |
Updates the default cleanup interval configuration value to 60m. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After HDDS-14829 snapshot diff cleanup has been decoupled with snapshot diff job re-submission. So, the job does not need to be aggressively cleaned up to allow re-submission and risk missing the actual job status because it has been cleaned up.
If a snapshot diff job generates a partial report before it is classified as failed / is cancelled then, the cleanup skips removal of the report entries because
totalDiffEntriesis not updated for these jobs and cleanup only cleans jobs withtotalDiffEntries > 0.Proposed to
totalDiffEntries > 0i.e., cleanup job does a deleteRange for all jobs in the purged table.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15166
How was this patch tested?
Unit tests