HDDS-15257. [DiskBalancer] Add CLOSING state to the "not movable" check

[Gargi-jais11]

What changes were proposed in this pull request?

isOpenToWriteState(state) only returns true for OPEN and RECOVERING:

  public static boolean isOpenToWriteState(State state) {
    return state == State.OPEN || state == State.RECOVERING;
  } 

CLOSING is not covered. So when this validation in DiskBalancerConfiguration runs, it only blocks OPEN, RECOVERING, and DELETED. A user who configures movableContainerStates = CLOSING would not get an error — the config would silently allow DiskBalancer to try to move containers in CLOSING state.

Fix:

if (HddsUtils.isOpenToWriteState(state) || state == State.CLOSING || state == State.DELETED) {
    throw new IllegalArgumentException("State " + name + " is not movable.");
} 
 

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15257

How was this patch tested?

Updated unit test and tested manually.

[ChenSammi]

Thanks @Gargi-jais11 .