HDDS-15254. Pass OZONE_OPTS to more containers to ensure coverage collection#10262
Merged
Conversation
adoroszlai
requested review from
ChenSammi,
SaketaChalamchala,
dombizita and
sarvekshayr
ChenSammi
reviewed
May 14, 2026
| env_file: | ||
| - vault.conf | ||
| environment: | ||
| - OZONE_OPTS=-Dcom.sun.net.ssl.checkRevocation=false |
Contributor
There was a problem hiding this comment.
Shall we also rename this to OZONE_OM_OPTS, instead of remove it, and add a new OZONE_OPTS too?
Contributor
Author
There was a problem hiding this comment.
This is being removed because the config is already defined in the base compose file (docker-compose.yaml). vault.yaml adds configs on top of that.
It was originally added for Vault, then added to the base file for some other project.
dombizita
approved these changes
May 14, 2026
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for this improvement (and reducing the code) @adoroszlai, looks good to me!
Contributor
Author
|
Thanks @ChenSammi, @dombizita for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Acceptance tests send coverage data via
jacoco-agent, defined inOZONE_OPTS:ozone/hadoop-ozone/dist/src/main/compose/test-all.sh
Line 37 in 8c89c58
For this we pass
OZONE_OPTSfrom local environment to containers (using the syntaxOZONE_OPTS:without value). This was missing in some compose definitions, and overwritten with different value in few specific cases, before this PR.Adding it increases coverage for code paths that are only tested in acceptance check, e.g. Vault integration.
https://issues.apache.org/jira/browse/HDDS-15254
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/25795532236