Skip to content

HDDS-15264. Fork RetryInvocationHandler from Hadoop#10263

Merged
adoroszlai merged 13 commits into
apache:masterfrom
adoroszlai:HDDS-15264
May 16, 2026
Merged

HDDS-15264. Fork RetryInvocationHandler from Hadoop#10263
adoroszlai merged 13 commits into
apache:masterfrom
adoroszlai:HDDS-15264

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Hadoop RetryInvocationHandler is coupled with RPC implementation. It references code in org.apache.hadoop.ipc and most importantly, keeps state in Client's static variables. Thus it should be forked, too, along with dependent classes.

This PR:

  • copies code from Hadoop as is from 3.2.4
  • backports some minor changes from 3.4.3
  • changes package name to org.apache.hadoop.io_.retry
  • removes Hadoop-specific InterfaceAudience/InterfaceStability
  • removes VisibleForTesting and unused code
  • changes existing Ozone code to use the forked classes

https://issues.apache.org/jira/browse/HDDS-15264

How was this patch tested?

https://github.com/adoroszlai/ozone/actions/runs/25825251785

@adoroszlai adoroszlai requested a review from ivandika3 May 14, 2026 01:10
@adoroszlai adoroszlai self-assigned this May 14, 2026
@adoroszlai adoroszlai requested a review from szetszwo May 14, 2026 12:24
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify the diff between the files in Hadoop and the files in this PR.

Copy link
Copy Markdown
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 526eec0 into apache:master May 16, 2026
48 checks passed
@adoroszlai adoroszlai deleted the HDDS-15264 branch May 16, 2026 17:48
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @szetszwo for the review.

Verify the diff between the files in Hadoop and the files in this PR.

I get "Not Found" when trying to open these.

@szetszwo
Copy link
Copy Markdown
Contributor

I get "Not Found" when trying to open these.

@adoroszlai , When I click the link, it will download the files even without signed it:
image

@adoroszlai
Copy link
Copy Markdown
Contributor Author

I get "Not Found" when trying to open these.

When I click the link, it will download the files

Thanks, now it works for me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants