HDDS-15278. DiskBalancer should validate persisted config before applying.#10271
Merged
Conversation
Contributor
Author
|
@Gargi-jais11 @ChenSammi Could you please help review this PR when you have time? This patch makes DiskBalancer validate persisted |
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @slfan1989 for catching this. Please find the inlined comment.
ChenSammi
approved these changes
May 15, 2026
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @slfan1989 , LGTM.
Contributor
Author
|
@Gargi-jais11 @ChenSammi Thanks for the review and for merging the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR validates persisted DiskBalancer configuration before applying it to the running service.
DiskBalancerService loads persisted configuration from diskbalancer.info and applies it through applyDiskBalancerInfo. Previously, only containerStates was explicitly validated in this path, while other fields such as threshold, bandwidthInMB, and parallelThread were applied directly from DiskBalancerInfo.
This PR updates applyDiskBalancerInfo to convert DiskBalancerInfo through DiskBalancerConfiguration, so the existing validation logic is reused consistently before updating the service state.
It also adds unit test coverage to verify that invalid persisted DiskBalancer configuration is rejected, including:
What is the link to the Apache JIRA
JIRA: HDDS-15278. DiskBalancer should validate persisted config before applying.
How was this patch tested?
Add Some Junit Test.