HDDS-15251. Move ScmInvokerCodeGenerator to test#10279
Merged
adoroszlai merged 5 commits intoMay 20, 2026
Merged
Conversation
szetszwo
reviewed
May 15, 2026
Comment on lines
-79
to
-81
| static void main(String[] args) { | ||
| ScmInvokerCodeGenerator.generate(DeletedBlockLogStateManager.class, true); | ||
| } |
Contributor
There was a problem hiding this comment.
Let's add the code somewhere in test. We may have a new class below
class ScmInvokerCodeGeneratorMains {
static class GenerateDeletedBlockLogStateManager {
static void main(String[] args) {
ScmInvokerCodeGenerator.generate(DeletedBlockLogStateManager.class, true);
}
}
}
Contributor
Author
Contributor
Author
szetszwo
approved these changes
May 19, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sonarcloud reports that ScmInvokerCodeGenerator has zero test coverage, while it does not require any tests (the generated code does). Let move it to tests.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15251
How was this patch tested?
CI