HDDS-15303. Enable prefix filter for OBS#10298
Merged
adoroszlai merged 1 commit intoMay 19, 2026
Merged
Conversation
Signed-off-by: peterxcli <peterxcli@gmail.com>
adoroszlai
reviewed
May 18, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @peterxcli for the patch, makes sense to me. I wonder why it was restricted to FSO previously.
ashishkumar50
approved these changes
May 19, 2026
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
Makes sense for OBS too.
Gargi-jais11
approved these changes
May 19, 2026
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @peterxcli for the patch. Enabling for OBS as well makes sense.
+1, LGTM!
Contributor
|
Thanks @peterxcli for the patch, @ashishkumar50, @Gargi-jais11, @ivandika3 for the review. |
Member
Author
@adoroszlai thanks for asking, I found the original pr for that filter: #5422, but I cant reason why. @ashishkumar50 could you share some insight? Thanks! |
Member
Author
|
Thanks @adoroszlai, @ivandika3, @ashishkumar50, @Gargi-jais11 for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tests:
Failure: Expected no keys for a missing prefix; Ozone returns keys such as b/a/c, b/a/g, b/a/r, and g.
Fix: also apply prefix filtering for
OBSWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15303
How was this patch tested?
UT and clean fork ci