Skip to content

HDDS-14104. Refactor RequestContext creation (#9493)#10319

Merged
smengcl merged 1 commit into
apache:ozone-2.1from
fmorg-git:HDDS-14104-2.1-release
May 21, 2026
Merged

HDDS-14104. Refactor RequestContext creation (#9493)#10319
smengcl merged 1 commit into
apache:ozone-2.1from
fmorg-git:HDDS-14104-2.1-release

Conversation

@fmorg-git
Copy link
Copy Markdown
Contributor

(cherry picked from commit 59ad0a1)

Conflicts:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/RequestContext.java

Please describe your PR in detail:

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14104

How was this patch tested?

n/a cherry-picked commit

(cherry picked from commit 59ad0a1)

 Conflicts:
	hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/RequestContext.java
@fmorg-git
Copy link
Copy Markdown
Contributor Author

hi @ChenSammi @jojochuang @smengcl - this PR is ready to review. Thanks!

@adoroszlai
Copy link
Copy Markdown
Contributor

Thanks @fmorg-git for the PR. We usually backport commits in batch to reduce overhead (example: #8211). Also, please wait for clean CI run in fork before opening PR.

@fmorg-git
Copy link
Copy Markdown
Contributor Author

Thanks @fmorg-git for the PR. We usually backport commits in batch to reduce overhead (example: #8211). Also, please wait for clean CI run in fork before opening PR.

Ok thanks

@smengcl
Copy link
Copy Markdown
Contributor

smengcl commented May 20, 2026

Code review

No issues found. Verified this is a faithful backport of upstream commit 59ad0a1 (HDDS-14104, #9493) to ozone-2.1:

  • All 5 files in PR HEAD 9906194 end at the same blob as upstream master post-merge (RequestContext.java44e0f928; the 4 test files have identical blob SHAs to upstream).
  • The cherry-pick conflict in RequestContext.java was caused by the HDDS-13753 ipcipc_ import rename being present on master but not on ozone-2.1. Resolution is correct: HDDS-14104 deletes both the import and its only caller (getBuilder(ugi, aclType, ownerName)) entirely, so the package-name divergence is moot.
  • All callers of the removed APIs (new RequestContext(...), new RequestContext.Builder(), getBuilder(...)) on ozone-2.1 are tests, all updated by this PR. No production callers are left broken.
  • All reviewer feedback from upstream PR HDDS-14104. Refactor RequestContext creation #9493 is preserved in the backport.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Copy link
Copy Markdown
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smengcl smengcl merged commit a589d73 into apache:ozone-2.1 May 21, 2026
81 of 83 checks passed
@smengcl
Copy link
Copy Markdown
Contributor

smengcl commented May 21, 2026

Merged to ozone-2.1 branch. Thanks @fmorg-git , @adoroszlai

@fmorg-git
Copy link
Copy Markdown
Contributor Author

Thanks all for the review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants