HDDS-13855. Move ACL check in Key and Prefix requests to preExecute#10330
Open
ss77892 wants to merge 1 commit into
Open
HDDS-13855. Move ACL check in Key and Prefix requests to preExecute#10330ss77892 wants to merge 1 commit into
ss77892 wants to merge 1 commit into
Conversation
Move ACL authorization checks for key operations (delete-keys, rename-keys) and key/prefix ACL operations (add, remove, set ACL, including FSO variants) from validateAndUpdateCache to preExecute. For bulk operations (OMKeysDeleteRequest, OMKeysRenameRequest), keys that fail the ACL check are collected in new proto fields (aclDeniedKeys / aclDeniedRenameKeys) and removed from the batch so the remaining permitted keys can still be processed. Proto changes: add aclDeniedKeys to DeleteKeyArgs and aclDeniedRenameKeys to RenameKeysArgs. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteKeys,RenameKeys) fromvalidateAndUpdateCachetopreExecuteOMKeyAclRequest,OMKeyAclRequestWithFSO,OMPrefixAclRequest, and FSO add/remove/set variants) fromvalidateAndUpdateCachetopreExecuteaclDeniedKeys/aclDeniedRenameKeys) and removed from the batch, so permitted keys in the same request can still be processedaclDeniedKeystoDeleteKeyArgsandaclDeniedRenameKeystoRenameKeysArgsMotivation
When ACL enforcement happens inside
validateAndUpdateCache, the request has already been written to the Ratis log on all OM peers. Moving the check topreExecute(which runs only on the leader, before log submission) prevents unauthorized requests from polluting the log and ensures consistent ACL rejection across HA leader changes.Test plan
TestOMHALeaderSpecificACLEnforcementcovers key operations (in a follow-up PR)Related
Part of HDDS-13855. See also:
Made with Cursor