HDDS-15346. DiskBalancer should update delta sizes atomically.#10333
Open
slfan1989 wants to merge 1 commit into
Open
HDDS-15346. DiskBalancer should update delta sizes atomically.#10333slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates DiskBalancer delta size tracking to use atomic map updates.
DiskBalancer uses
deltaSizesto track scheduled bytes per source volume. Previously, some updates were done with separate read and write operations, such asgetOrDefault(...)followed byput(...). These operations are not atomic, so concurrent DiskBalancer tasks updating the same source volume could overwrite each other and leave an incorrect delta size.This change introduces helper methods to reserve and release delta size using
ConcurrentHashMap.compute(...), so each per-volume update is applied atomically. It also removes zero-value entries after the reserved bytes are fully released.A unit test is added to cover concurrent task completion and verify that the delta size is restored correctly.
What is the link to the Apache JIRA
JIRA: HDDS-15346. DiskBalancer should update delta sizes atomically.
How was this patch tested?
Added unit test.