HDDS-15322. Add tests for ScmInvoker subclasses.#10336
Merged
Merged
Conversation
Russole
reviewed
May 24, 2026
| final File tmp = new File(DIR, invokerClassName + "_tmp.java"); | ||
| final File tmp = new File(dir, invokerClassName + "_tmp.java"); | ||
| if (tmp.exists()) { | ||
| throw new IOException("Already exist: " + java.getAbsolutePath()); |
Contributor
There was a problem hiding this comment.
Although this was not introduced in this PR, since this method is being touched, should this error message use tmp.getAbsolutePath() instead of java.getAbsolutePath() ? The file that already exists here is tmp.
Contributor
|
Thanks @szetszwo for working on this. Overall LGTM, just one minor comment. |
Russole
approved these changes
May 24, 2026
Contributor
Russole
left a comment
Russole
left a comment
There was a problem hiding this comment.
The changes look good to me. LGTM!
Contributor
Author
|
@Russole , thanks for reviewing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See HDDS-15322
What is the link to the Apache JIRA
HDDS-15322
How was this patch tested?
Added new tests.