-
Notifications
You must be signed in to change notification settings - Fork 605
HDDS-14443. Documentation and Scripting Inconsistencies for Ozone Environment Variables #10352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chihsuan
wants to merge
5
commits into
apache:master
Choose a base branch
from
chihsuan:HDDS-14443
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−19
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dae0ac4
HDDS-14443. Add OZONE_HTTPFS_OPTS support for the httpfs subcommand
chihsuan f9bd890
HDDS-14443. Document missing component _OPTS variables in ozone-env.sh
chihsuan dcc3fac
HDDS-14443. Document OZONE_SERVER_OPTS, OZONE_WORKER_NAMES, jsvc and …
chihsuan 55ec56e
HDDS-14443. Correct OZONE_SECURE_LOG to OZONE_SECURE_LOG_DIR in ozone…
chihsuan e2215ea
HDDS-14443. Remove unused OZONE_GC_SETTINGS and OZONE_SECURE_IDENT_PR…
chihsuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One subtle point: this follows the existing
OZONE_S3G_OPTS/OZONE_RECON_OPTSpattern by appending the built-in defaults after the user-provided component opts. That means user-provided duplicate-Dhttpfs.*properties inOZONE_HTTPFS_OPTSwill not override the built-in HttpFS properties, because Java uses the last duplicate -D value.I think this is acceptable for consistency with the other daemons, which is the explicit goal of HDDS-14443.
OZONE_HTTPFS_OPTSis meant for adding JVM options; letting users override the built-inhttpfs.*paths would be a broader, cross-daemon change and is out of scope here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 this is good.