HDDS-15369. Fix datanode shutdown on ozone.scm.nodes reconfig#10358
Merged
Conversation
ivandika3
approved these changes
May 26, 2026
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
LGTM +1. Thanks for catching this bug.
adoroszlai
reviewed
May 26, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @xichen01 for the patch, @ivandika3 for the review.
Comment on lines
+45
to
+46
| Assertions.assertTrue(connectionManager.getValues().isEmpty()); | ||
| Assertions.assertEquals(HEARTBEAT, endpoint.getState()); |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue
connectionManager.removeSCMServeris called, in theremoveSCMServer, the endpoint State will be set toSHUTDOWNRunningDatanodeStateis: whenever any endpoint task returnsSHUTDOWN, the entire DN state machine switches toSHUTDOWN, this will cause the DN exceptional shutdown.FIx
Do not set the endpoint to be removed to the
SHUTDOWNstateWhat is the link to the Apache JIRA
HDDS-15369
How was this patch tested?
unit test