HDDS-15354. Fix nested tab completion in ozone interactive#10359
Merged
Conversation
Add Picocli aliases on nested CLIs so keys used by OzoneInteractiveShell match tab-completion lookup.
adoroszlai
approved these changes
May 26, 2026
Contributor
|
Thanks @will-sh for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-15354. Fix nested tab completion in ozone interactive
After HDDS-15185 introduced the top-level ozone interactive entry point (ozone-cli-interactive), users can reach nested CLIs with short names such as sh, s3, tenant, admin, and debug. Tab completion worked for those top-level tokens but failed for deeper input (for example sh vol, sh vol create).
This change adds Picocli aliases on the nested CLI root commands so the names registered by OzoneInteractiveShell match what the JLine/picocli completer uses when resolving subcommands.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15354
How was this patch tested?
Manual — ozone interactive (cluster or compose env with Ozone CLI built from this branch):
Start ozone interactive.
Tab-complete top-level: sh, s3, tenant, admin, debug.
Tab-complete nested paths, e.g. sh → vol / bucket / key, and at least one deeper level (e.g. sh vol → subcommands).
Confirm behavior matches ozone sh --interactive for nested completion where applicable.
CI - Passed