HDDS-15368. Remove static horizontal divider from ozone interactive shell#10374
Merged
Conversation
Add Picocli aliases on nested CLIs so keys used by OzoneInteractiveShell match tab-completion lookup.
adoroszlai
approved these changes
May 28, 2026
Contributor
|
Thanks @will-sh for the improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-15368. Remove static horizontal divider from ozone interactive shell
The ozone interactive REPL (introduced under HDDS-11825) used JLine TailTipWidgets with TipType.COMPLETER to show command synopsis below Tab completion. That integration also enabled the JLine Status pane with a static horizontal border (────), which sometimes could caused poor UX when the terminal was resized, copied, or when completion overlapped.
This change removes TailTipWidgets from the interactive REPL and relies on LineReader-only tab completion (AUTO_LIST, LIST_AMBIGUOUS, LIST_MAX=50). That eliminates the Status border and the duplicate or “ghost” completion lines seen after window resize (WINCH). A blank line is printed after each command (and after the startup banner) so the prompt is visually separated without a hardcoded rule line—aligned with common shells such as mysql and spark-shell.
Additionally, a small startup banner (OzoneInteractiveWelcome) is shown when entering ozone interactive: Ozone release version, configured OM/SCM endpoints, and short hints for help, Tab completion, and ozone version. Shell exposes an interactiveWelcomeLines() hook (default empty); OzoneInteractiveShell overrides it to supply the banner.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15368
How was this patch tested?
Currently it is like below: