HDDS-15413. Recon and SCM Container Sync Metrics addition.#10384
Open
devmadhuu wants to merge 2 commits into
Open
HDDS-15413. Recon and SCM Container Sync Metrics addition.#10384devmadhuu wants to merge 2 commits into
devmadhuu wants to merge 2 commits into
Conversation
sumitagrawl
reviewed
Jun 5, 2026
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@devmadhuu Thanks for working over this, given few comments
| }; | ||
|
|
||
| private static final MetricsInfo TARGETED_SYNC_STATUS = Interns.info( | ||
| "targetedSyncStatus", |
Contributor
There was a problem hiding this comment.
can be renamed as scmContainerSyncStatus
| private final Map<HddsProtos.LifeCycleState, AtomicLong> | ||
| lastContainerSyncDurationMs; | ||
| private final Map<HddsProtos.LifeCycleState, AtomicLong> | ||
| lastContainerCountDrift; |
Contributor
There was a problem hiding this comment.
we need not capture last metrics of ContainerSync / Count / duration as this will be captured by grafana
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR extends
ReconScmContainerSyncMetricsto expose per-state metrics for the four actively reconciled container states:OPENQUASI_CLOSEDCLOSEDDELETEDFor each state, Recon now reports:
SCM count - Recon count.The existing overall targeted sync metrics remain unchanged:
targetedSyncStatuslastTargetedSyncDurationMsWhy are the changes needed?
Recon periodically syncs container state from SCM, every 6 hours by default. Before this change, metrics only showed the overall targeted sync status and total duration. Admins could not tell:
The new metrics make this visible in Hadoop metrics and downstream Prometheus time-series data.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15413
How was this patch tested?
Ran the below tests:
TestReconStorageContainerSyncHelper,TestReconScmContainerSyncMetrics