HDDS-15441. [DiskBalancer] Fix DiskBalancer documentation inconsistencies.#10399
Open
slfan1989 wants to merge 6 commits into
Open
HDDS-15441. [DiskBalancer] Fix DiskBalancer documentation inconsistencies.#10399slfan1989 wants to merge 6 commits into
slfan1989 wants to merge 6 commits into
Conversation
Contributor
sreejasahithi
left a comment
sreejasahithi
left a comment
There was a problem hiding this comment.
Thanks @slfan1989 for fixing the doc
Gargi-jais11
reviewed
Jun 1, 2026
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @slfan1989 for catching these inconsistencies.
Please find inlined comments.
amaliujia
reviewed
Jun 1, 2026
| | `hdds.datanode.disk.balancer.container.choosing.policy` | `org.apache.hadoop.ozone.container.diskbalancer.policy.DefaultContainerChoosingPolicy` | 用于选择源/目标卷以及要移动的容器的策略。 | | ||
| | `hdds.datanode.disk.balancer.service.timeout` | `300s` | Datanode DiskBalancer 服务操作超时。 | | ||
| | `hdds.datanode.disk.balancer.should.run.default` | `false` | 如果平衡器无法读取其持久配置，则该值决定服务是否应默认运行。 | | ||
|
|
Contributor
There was a problem hiding this comment.
I believe we need a newline at end of a file?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out! I verified the Chinese documentation now ends with a newline.
Contributor
There was a problem hiding this comment.
@slfan1989 thanks for adding the newline, but the same applies to the English doc as well
Co-authored-by: Gargi Jaiswal <134698352+Gargi-jais11@users.noreply.github.com>
Contributor
|
@slfan1989 please resolve the merge conflicts. |
Gargi-jais11
reviewed
Jun 3, 2026
| | `hdds.datanode.disk.balancer.container.states` | `CLOSED,QUASI_CLOSED` | Comma-separated container lifecycle state names that may be moved between disks (must match enum names exactly, uppercase). Default includes **CLOSED** and **QUASI_CLOSED**; extend the list when additional states are needed to be balanced. All defined container states which are eligibile to move QUASI_CLOSED, CLOSED, UNHEALTHY, INVALID. | | ||
| | `hdds.datanode.disk.balancer.container.choosing.policy` | `org.apache.hadoop.ozone.container.diskbalancer.policy.DefaultContainerChoosingPolicy` | The policy for selecting source/destination volumes and which containers to move. | | ||
| | `hdds.datanode.disk.balancer.service.timeout` | `300s` | Timeout for the Datanode DiskBalancer service operations. | | ||
| | `hdds.datanode.disk.balancer.should.run.default` | `false` | If the balancer fails to read its persisted configuration, this value determines if the service should run by default. | |
Contributor
There was a problem hiding this comment.
Nit: Please add a new line at the end of file.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out. I verified both the English and Chinese DiskBalancer docs now end with a newline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes several inconsistencies in the English and Chinese DiskBalancer documentation.
The DiskBalancer docs had examples and default values that did not match the current implementation:
The feature flag section said DiskBalancer should be enabled by setting the property to
true, but the example usedhdds.datanode.disk.balancer.enabled = false.The
--parallel-threadoption documented the default as 1, while the code default is5.The Chinese doc documented
--stop-after-disk-evendefault asfalse, while the code default istrue.The
--container-statesexample usedOPEN,CLOSED, butOPENis rejected by DiskBalancer validation because open-to-write container states are not movable.The Chinese configuration table had an extra table separator in the
hdds.datanode.disk.balancer.enabledrow.This PR updates both
DiskBalancer.mdandDiskBalancer.zh.mdso that the documented examples and defaults match the current code and avoid suggesting invalid configuration values.What is the link to the Apache JIRA
HDDS-15441. [DiskBalancer] Fix DiskBalancer documentation inconsistencies.
How was this patch tested?
This is a documentation-only change.