HDDS-15468. Replace langchain4j-bom, guice-bom due to leaked dependencies#10421
Merged
Conversation
Contributor
|
@adoroszlai Thanks for the fix! I pulled down your branch and ran a live test against the Recon chatbot to make sure removing the BOM didn't break the LLM integration. I generated some data using Freon and ran a few queries. Everything is resolving correctly and the chatbot works perfectly. Here are the responses from the test: Query: What is the cluster state? The Ozone cluster is currently in a **healthy state** with **one datanode** and **one pipeline** operational.
Here's a summary of the cluster's state:
- **Datanodes:**
- Total Datanodes: **1**
- Healthy Datanodes: **1**
- **Pipelines:** **1**
- **Containers:**
- Total Containers: **1**
- Open Containers: **1**
- Missing Containers: **0**
- Deleted Containers: **0**
- **Storage Report:**
- Capacity: **149.27 GB** (149,266,245,387 bytes)
- Used: **4.38 MB** (4,382,720 bytes)
- Remaining: **42.25 GB** (42,251,796,480 bytes)
- Filesystem Capacity: **149.28 GB** (149,281,173,504 bytes)
- Filesystem Used: **107.03 GB** (107,029,377,024 bytes)
- Filesystem Available: **42.25 GB** (42,251,796,480 bytes)
- Minimum Free Space: **100 MB** (104,857,600 bytes)
- **Volumes:** **2**
- **Buckets:** **1**
- **Keys:** **0**
- **Keys Pending Deletion:** **0**Query: How many datanodes are healthy? Based on the cluster state, there is **1 healthy datanode**.Query: Show me all pipelines There is **1 pipeline** currently in your Ozone cluster.
Here are the details for the pipeline:
- **Pipeline ID**: `71eb2a50-3acd-4a47-acfa-1483d5ad289a`
- **Status**: `OPEN`
- **Leader Node**: `ozone-datanode-1.ozone_default`
- **Replication Type**: `RATIS`
- **Replication Factor**: `ONE`
- **Datanodes in Pipeline**:
- `ozone-datanode-1.ozone_default` (IP: `172.29.0.4`, UUID: `2a15fd8d-8303-4768-a2f8-13332bb1be71`)
- **Containers**: 1 |
Contributor
Author
|
Thanks @ArafatKhan2198 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
langchain4j-bomandguice-bomleak transitive dependencies defined in their parent POMs.This overrides some of Ozone's own dependencies. Example for production dependency:
Some test artifacts are also overridden, which was previously worked around by adding these dependencies again, despite having been imported from their own BOMs:
ozone/pom.xml
Line 1613 in 891cf0e
ozone/pom.xml
Line 1679 in 891cf0e
This change replaces usage of these two BOMs with individual artifacts.
https://issues.apache.org/jira/browse/HDDS-15468
How was this patch tested?
Verified
slf4j-apiversion after build.Compared effective POM before/after the change. Effective POM (with BOMs imported, properties substituted etc.) can be generated as:
https://github.com/adoroszlai/ozone/actions/runs/26864255402