Skip to content

HDDS-15473. TestOmSnapshotObjectStore should run with createLinkedBucket=false#10425

Merged
adoroszlai merged 1 commit into
apache:masterfrom
chihsuan:HDDS-15473
Jun 4, 2026
Merged

HDDS-15473. TestOmSnapshotObjectStore should run with createLinkedBucket=false#10425
adoroszlai merged 1 commit into
apache:masterfrom
chihsuan:HDDS-15473

Conversation

@chihsuan
Copy link
Copy Markdown
Contributor

@chihsuan chihsuan commented Jun 3, 2026

What changes were proposed in this pull request?

TestOmSnapshotObjectStore and TestOmSnapshotObjectStoreWithLinkedBuckets both call super(OBJECT_STORE, false, false, false, true). They are therefore identical, and the non-linked OBJECT_STORE` snapshot path is no longer exercised by any test.

public class TestOmSnapshotObjectStore extends TestOmSnapshot {
public TestOmSnapshotObjectStore() throws Exception {
super(OBJECT_STORE, false, false, false, true);
}
}

public class TestOmSnapshotObjectStoreWithLinkedBuckets extends TestOmSnapshot {
public TestOmSnapshotObjectStoreWithLinkedBuckets() throws Exception {
super(OBJECT_STORE, false, false, false, true);
}
}

This was introduced in HDDS-11705 (#7434), which added TestOmSnapshotObjectStoreWithLinkedBuckets and converted TestOmSnapshotObjectStore's constructor from 4 to 5 arguments, passing true for the new createLinkedBucket flag instead of false.

This PR changes TestOmSnapshotObjectStore to pass createLinkedBucket=false, restoring coverage of the non-linked path. This matches the non-linked/linked pairing that every other layout already has (TestOmSnapshotFsoWithNativeLib vs ...WithLinkedBuckets, TestOmSnapshotWithoutBucketLinkingLegacy vs TestOmSnapshotWithBucketLinkingLegacy).

Noted as a side observation in HDDS-10308, but it is a coverage correctness issue, not a speedup, so address it separately.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15473

How was this patch tested?

Existing TestOmSnapshotObjectStore integration test, now exercising the non-linked OBJECT_STORE path. Verified via the CI workflow run on the fork. https://github.com/chihsuan/ozone/actions/runs/26890673615/job/79318188405#step:13:5621

@chihsuan chihsuan marked this pull request as ready for review June 3, 2026 15:36
@adoroszlai adoroszlai merged commit 7553aa0 into apache:master Jun 4, 2026
75 of 78 checks passed
@adoroszlai
Copy link
Copy Markdown
Contributor

Thanks @chihsuan for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants