HDDS-15473. TestOmSnapshotObjectStore should run with createLinkedBucket=false#10425
Merged
Conversation
adoroszlai
approved these changes
Jun 3, 2026
Contributor
|
Thanks @chihsuan for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestOmSnapshotObjectStoreandTestOmSnapshotObjectStoreWithLinkedBucketsboth callsuper(OBJECT_STORE, false, false, false, true). They are therefore identical, and the non-linkedOBJECT_STORE` snapshot path is no longer exercised by any test.ozone/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotObjectStore.java
Lines 25 to 30 in 547ac88
ozone/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotObjectStoreWithLinkedBuckets.java
Lines 25 to 30 in dcc6edf
This was introduced in HDDS-11705 (#7434), which added
TestOmSnapshotObjectStoreWithLinkedBucketsand convertedTestOmSnapshotObjectStore's constructor from 4 to 5 arguments, passingtruefor the newcreateLinkedBucketflag instead offalse.This PR changes
TestOmSnapshotObjectStoreto passcreateLinkedBucket=false, restoring coverage of the non-linked path. This matches the non-linked/linked pairing that every other layout already has (TestOmSnapshotFsoWithNativeLibvs...WithLinkedBuckets,TestOmSnapshotWithoutBucketLinkingLegacyvsTestOmSnapshotWithBucketLinkingLegacy).Noted as a side observation in HDDS-10308, but it is a coverage correctness issue, not a speedup, so address it separately.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15473
How was this patch tested?
Existing
TestOmSnapshotObjectStoreintegration test, now exercising the non-linkedOBJECT_STOREpath. Verified via the CI workflow run on the fork. https://github.com/chihsuan/ozone/actions/runs/26890673615/job/79318188405#step:13:5621