HDDS-15700. flaky-test-check green despite failing tests#10626
Merged
Conversation
Contributor
Author
|
Thanks @dombizita for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-15589 introduced a bug in
flaky-test-checkwhere splits are not marked as failed. Workflow summary still shows splits exited with error code 1 (i.e. failure). Example:https://github.com/chihsuan/ozone/actions/runs/28250989222
The problem is that
Execute testspasses due tocontinue-on-error, andSummary of failuresonly runs onfailure. To ensure that failure is properly reported, removecontinue-on-error.https://issues.apache.org/jira/browse/HDDS-15700
How was this patch tested?
Passing
flaky-test-checkis green:https://github.com/adoroszlai/ozone/actions/runs/28290160719
Failing
flaky-test-checkis red:https://github.com/adoroszlai/ozone/actions/runs/28290150197