Skip to content

Comments

HDDS-4406. Run MiniOzoneChaosCluster via github actions.#1532

Closed
mukul1987 wants to merge 1 commit intoapache:masterfrom
mukul1987:HDDS-4406
Closed

HDDS-4406. Run MiniOzoneChaosCluster via github actions.#1532
mukul1987 wants to merge 1 commit intoapache:masterfrom
mukul1987:HDDS-4406

Conversation

@mukul1987
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

What is the link to the Apache JIRA

(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukul1987 the change. Overall it looks good to me.

One missing point might be the collection of available logs as artifacts.

To make it easier I would suggest following the existing convention and create a hadoop-ozone/dev-support/checks/chaos.sh which executes the chaos test and collects all require results under the "$REPORT_DIR".

It would help us to be independent of github actions and execute chaos test in any other (external or internal) environments.

java: [ 8, 11 ]
fail-fast: false
steps:
- name: Setup link to SSD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: are you sure that root is not on SSD. I know that this secondary partition has more space, but didn't know that it has different hardware (SSD vs HDD).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from post-commit.yml, where I added this name based on my understanding of the GitHub-hosted runner specification. It says "14 GB of SSD disk space", which matches /mnt, but not the other mount, which has more total space but less free of it.

@mukul1987 mukul1987 marked this pull request as draft November 12, 2020 18:35
@mukul1987 mukul1987 closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants