HDDS-4441. Add metrics for ACL related operations.

[ayushtkn]

What changes were proposed in this pull request?

Add acl related metrics in OM

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4441

How was this patch tested?

Added UT

[ayushtkn]

Thanx @jojochuang for the review!!!

[cxorm]

Thanks @ayushtkn for the contribution.

IMHO the setAcl, removeAcl and addAcl are write-operation, the metrics should be updated in OMRequest instead of OzoneManager.
(For example, when we set acl of some volume, we should update the metric in OMVolumeSetAclRequest)

I think we could do it in a new jira.
Could you be so kind as to file a jira to update it ? (Feel free to correct me if I miss something, thanks)

[ayushtkn]

Thanx @cxorm I will raise one jira for that. But I didn't actually catch what to do.
createDirectory, createFile are also write calls, for them the metrics are also updated in OM.
I couldn't find any metrics instance itself in OMVolumeSetAclRequest and why we can't update the metrics in OM?
And the metrics being updated is OMMetrics, So, that should track statistics of OM only?

[cxorm]

createDirectory, createFile are also write calls, for them the metrics are also updated in OM.
I couldn't find any metrics instance itself in OMVolumeSetAclRequest and why we can't update the metrics in OM?

Yeah it's a good question,
for OMHA, actually the write-operation of OzoneManager is processed by OMRequest instead of OzoneManager.
(The write calls in OzoneManager is deprecated, but the code is not removed.)

And the metrics being updated is OMMetrics, So, that should track statistics of OM only?

Right, it is used to track statistics of OM (But the write calls of OM is processed by OMRequest.)

[ayushtkn]

Ohh, Means for HA, the code flow is separate. I thought OzoneManager like the NamenodeRpcServer. It should be mentioned somewhere it is only for Non-HA :-(
Well, Thanx @cxorm for the explanation. I have tried to handle this for HA, in an Addendum PR - #1584

Please have a look

[bharatviswa504]

For HA/non-HA new code is being used for write requests.

I belive there is a cleanup jira to remove the older methods.

[cxorm]

Thanks @bharatviswa504 , and yes I mean non-HA/ HA is using new code.
(Sorry for misleading it)